Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6246010: Add OWNERS files to bookmarks, gtk, and status_icons subdirs. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add OWNERS files to bookmarks, gtk, and status_icons subdirs. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71890

Patch Set 1 #

Patch Set 2 : remove evan and move file #

Total comments: 3

Patch Set 3 : alphabetical #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A chrome/browser/bookmarks/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/status_icons/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/ui/gtk/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
tfarina
9 years, 11 months ago (2011-01-19 16:06:34 UTC) #1
sky
I'm fine with bookmarks/OWNERS . gtk/OWNERS looks good, but Evan^2 and Elliot will have to ...
9 years, 11 months ago (2011-01-19 16:24:13 UTC) #2
Andrew T Wilson (Slow)
status_icons LGTM
9 years, 11 months ago (2011-01-19 17:19:57 UTC) #3
tfarina
Ping Stade.
9 years, 11 months ago (2011-01-19 22:35:17 UTC) #4
Evan Stade
isn't browser/gtk moving to browser/ui/gtk
9 years, 11 months ago (2011-01-19 22:51:10 UTC) #5
tfarina
On 2011/01/19 22:51:10, Evan Stade wrote: > isn't browser/gtk moving to browser/ui/gtk Doh, yeah, I'm ...
9 years, 11 months ago (2011-01-19 22:52:35 UTC) #6
Evan Stade
ask Evan@ if he wants to be on that list. He's not really actively developing ...
9 years, 11 months ago (2011-01-19 23:05:04 UTC) #7
tfarina
Evan, do you want to be added to gtk OWNERS file?
9 years, 11 months ago (2011-01-19 23:12:41 UTC) #8
evanm
No thanks! I'm sure the other e's have it covered. :)
9 years, 11 months ago (2011-01-19 23:16:29 UTC) #9
tfarina
On 2011/01/19 23:16:29, evanm wrote: > No thanks! I'm sure the other e's have it ...
9 years, 11 months ago (2011-01-19 23:20:51 UTC) #10
Evan Stade
LGTM http://codereview.chromium.org/6246010/diff/3002/chrome/browser/ui/gtk/OWNERS File chrome/browser/ui/gtk/OWNERS (right): http://codereview.chromium.org/6246010/diff/3002/chrome/browser/ui/gtk/OWNERS#newcode2 chrome/browser/ui/gtk/OWNERS:2: erg@chromium.org alphabetize (?)
9 years, 11 months ago (2011-01-19 23:35:05 UTC) #11
tfarina
http://codereview.chromium.org/6246010/diff/3002/chrome/browser/ui/gtk/OWNERS File chrome/browser/ui/gtk/OWNERS (right): http://codereview.chromium.org/6246010/diff/3002/chrome/browser/ui/gtk/OWNERS#newcode2 chrome/browser/ui/gtk/OWNERS:2: erg@chromium.org On 2011/01/19 23:35:05, Evan Stade wrote: > alphabetize ...
9 years, 11 months ago (2011-01-19 23:42:24 UTC) #12
tfarina
9 years, 11 months ago (2011-01-20 00:50:32 UTC) #13 
http://codereview.chromium.org/6246010/diff/3002/chrome/browser/ui/gtk/OWNERS
File chrome/browser/ui/gtk/OWNERS (right):

http://codereview.chromium.org/6246010/diff/3002/chrome/browser/ui/gtk/OWNERS...
chrome/browser/ui/gtk/OWNERS:2: erg@chromium.org
On 2011/01/19 23:35:05, Evan Stade wrote:
> alphabetize (?)

Done.

Powered by Google App Engine
This is Rietveld 408576698