Generate thumbnails in the browser process.

chrome/renderer/render_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_view.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 24 matching lines @@
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/file_system/file_system_dispatcher.h"
 #include "chrome/common/file_system/webfilesystem_callback_dispatcher.h"
 #include "chrome/common/json_value_serializer.h"
 #include "chrome/common/jstemplate_builder.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/page_zoom.h"
 #include "chrome/common/pepper_plugin_registry.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/renderer_preferences.h"
-#include "chrome/common/thumbnail_score.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/common/web_apps.h"
 #include "chrome/common/window_container_type.h"
 #include "chrome/renderer/about_handler.h"
 #include "chrome/renderer/audio_message_filter.h"
 #include "chrome/renderer/autofill_helper.h"
 #include "chrome/renderer/automation/dom_automation_controller.h"
 #include "chrome/renderer/blocked_plugin.h"
 #include "chrome/renderer/device_orientation_dispatcher.h"
 #include "chrome/renderer/devtools_agent.h"
@@ skipping 220 matching lines @@
 using webkit_glue::PasswordFormDomManager;
 using webkit_glue::ResourceFetcher;
 using webkit_glue::SiteIsolationMetrics;
 using webkit_glue::WebAccessibility;
 
 //-----------------------------------------------------------------------------
 
 typedef std::map<WebKit::WebView*, RenderView*> ViewMap;
 static base::LazyInstance<ViewMap> g_view_map(base::LINKER_INITIALIZED);
 
-// define to write the time necessary for thumbnail/DOM text retrieval,
-// respectively, into the system debug log
-// #define TIME_TEXT_RETRIEVAL
-
 // maximum number of characters in the document to index, any text beyond this
 // point will be clipped
 static const size_t kMaxIndexChars = 65535;
 
-// Size of the thumbnails that we'll generate
-static const int kThumbnailWidth = 212;
-static const int kThumbnailHeight = 132;
-
-// Delay in milliseconds that we'll wait before capturing the page contents
-// and thumbnail.
+// Delay in milliseconds that we'll wait before capturing the page contents.
 static const int kDelayForCaptureMs = 500;
 
 // Typically, we capture the page data once the page is loaded.
 // Sometimes, the page never finishes to load, preventing the page capture
 // To workaround this problem, we always perform a capture after the following
 // delay.
 static const int kDelayForForcedCaptureMs = 6000;
 
 // Time, in seconds, we delay before sending content state changes (such as form
 // state and scroll position) to the browser. We delay sending changes to avoid
@@ skipping 28 matching lines @@
     return false;
 
   view->paint(webkit_glue::ToWebCanvas(&canvas),
               WebRect(0, 0, size.width, size.height));
   // TODO: Add a way to snapshot the whole page, not just the currently
   // visible part.
 
   return true;
 }
 
-// Calculates how "boring" a thumbnail is. The boring score is the
-// 0,1 ranged percentage of pixels that are the most common
-// luma. Higher boring scores indicate that a higher percentage of a
-// bitmap are all the same brightness.
-static double CalculateBoringScore(SkBitmap* bitmap) {
-  int histogram[256] = {0};
-  color_utils::BuildLumaHistogram(bitmap, histogram);
-
-  int color_count = *std::max_element(histogram, histogram + 256);
-  int pixel_count = bitmap->width() * bitmap->height();
-  return static_cast<double>(color_count) / pixel_count;
-}
-
 // True if |frame| contains content that is white-listed for content settings.
 static bool IsWhitelistedForContentSettings(WebFrame* frame) {
   WebSecurityOrigin origin = frame->securityOrigin();
   if (origin.isEmpty())
     return false;  // Uninitialized document?
 
   if (EqualsASCII(origin.protocol(), chrome::kChromeUIScheme))
     return true;  // Browser UI elements should still work.
 
   // If the scheme is ftp: or file:, an empty file name indicates a directory
@@ skipping 585 matching lines @@
     child_process_logging::SetActiveURL(main_frame->url());
 
   ObserverListBase<RenderViewObserver>::Iterator it(observers_);
   RenderViewObserver* observer;
   while ((observer = it.GetNext()) != NULL)
     if (observer->OnMessageReceived(message))
       return true;
 
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(RenderView, message)
-    IPC_MESSAGE_HANDLER(ViewMsg_CaptureThumbnail, OnCaptureThumbnail)
     IPC_MESSAGE_HANDLER(ViewMsg_CaptureSnapshot, OnCaptureSnapshot)
     IPC_MESSAGE_HANDLER(ViewMsg_PrintPages, OnPrintPages)
     IPC_MESSAGE_HANDLER(ViewMsg_PrintingDone, OnPrintingDone)
     IPC_MESSAGE_HANDLER(ViewMsg_PrintPreview, OnPrintPreview)
     IPC_MESSAGE_HANDLER(ViewMsg_PrintNodeUnderContextMenu,
                         OnPrintNodeUnderContextMenu)
     IPC_MESSAGE_HANDLER(ViewMsg_Navigate, OnNavigate)
     IPC_MESSAGE_HANDLER(ViewMsg_Stop, OnStop)
     IPC_MESSAGE_HANDLER(ViewMsg_ReloadFrame, OnReloadFrame)
     IPC_MESSAGE_HANDLER(ViewMsg_Undo, OnUndo)
@@ skipping 118 matching lines @@
     IPC_MESSAGE_HANDLER(ViewMsg_JavaScriptStressTestControl,
                         OnJavaScriptStressTestControl)
     IPC_MESSAGE_HANDLER(ViewMsg_ContextMenuClosed, OnContextMenuClosed)
 
     // Have the super handle all other messages.
     IPC_MESSAGE_UNHANDLED(handled = RenderWidget::OnMessageReceived(message))
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
-void RenderView::OnCaptureThumbnail() {
-  WebFrame* main_frame = webview()->mainFrame();
-  if (!main_frame)
-    return;
-
-  // get the URL for this page
-  GURL url(main_frame->url());
-  if (url.is_empty())
-    return;
-
-  if (size_.IsEmpty())
-    return;  // Don't create an empty thumbnail!
-
-  ThumbnailScore score;
-  SkBitmap thumbnail;
-  if (!CaptureThumbnail(webview(), kThumbnailWidth, kThumbnailHeight,
-                        &thumbnail, &score))
-    return;
-
-  // send the thumbnail message to the browser process
-  Send(new ViewHostMsg_Thumbnail(routing_id_, url, score, thumbnail));
-}
-
 void RenderView::OnCaptureSnapshot() {
   SkBitmap snapshot;
   bool error = false;
 
   WebFrame* main_frame = webview()->mainFrame();
   if (!main_frame)
     error = true;
 
   if (!error && !CaptureSnapshot(webview(), &snapshot))
     error = true;
@@ skipping 61 matching lines @@
 
   WebFrame* main_frame = webview()->mainFrame();
   if (!main_frame)
     return;
 
   // Don't index/capture pages that are in view source mode.
   if (main_frame->isViewSourceModeEnabled())
     return;
 
   // Don't index/capture pages that failed to load.  This only checks the top
-  // level frame so the thumbnail may contain a frame that failed to load.
+  // level frame.
   WebDataSource* ds = main_frame->dataSource();
   if (ds && ds->hasUnreachableURL())
     return;
 
   if (!preliminary_capture)
     last_indexed_page_id_ = load_id;
 
   // Get the URL for this page.
   GURL url(main_frame->url());
   if (url.is_empty())
@@ skipping 14 matching lines @@
       UMA_HISTOGRAM_MEDIUM_TIMES("Renderer4.LanguageDetection",
                                  base::TimeTicks::Now() - begin_time);
     }
     // Send the text to the browser for indexing (the browser might decide not
     // to index, if the URL is HTTPS for instance) and language discovery.
     Send(new ViewHostMsg_PageContents(
         routing_id_, url, load_id, contents, language,
         TranslateHelper::IsPageTranslatable(&document)));
   }
 
-  OnCaptureThumbnail();
-
   if (phishing_delegate_.get())
     phishing_delegate_->FinishedLoad(&contents);
 }
 
 void RenderView::CaptureText(WebFrame* frame, string16* contents) {
   contents->clear();
   if (!frame)
     return;
 
 #ifdef TIME_TEXT_RETRIEVAL
@@ skipping 15 matching lines @@
   // partial word indexed at the end that might have been clipped. Therefore,
   // terminate the string at the last space to ensure no words are clipped.
   if (contents->size() == kMaxIndexChars) {
     size_t last_space_index = contents->find_last_of(kWhitespaceUTF16);
     if (last_space_index == std::wstring::npos)
       return;  // don't index if we got a huge block of text with no spaces
     contents->resize(last_space_index);
   }
 }
 
-bool RenderView::CaptureThumbnail(WebView* view,

[brettw, 2011/01/18 18:25:42]

I think we probably want to keep the old code and have your new feature
controlled by a command-line switch. This way, you can land a
partially-implemented patch and continue to work without disturbing people on
the dev channel, and it can be turned off on the beta channel if we think it
might be causing problems or isn't ready.

Hopefully adding this is self-explanatory. The thing that people usually forget
is to modify BrowserRenderProcessHost::PropagateBrowserCommandLineToRenderer if
they need the command line switch in the renderer.

[satorux1, 2011/01/19 01:36:36]

That's a great idea. I'll change it accordingly.

-                                  int w,
-                                  int h,
-                                  SkBitmap* thumbnail,
-                                  ThumbnailScore* score) {
-  base::TimeTicks beginning_time = base::TimeTicks::Now();
-
-  skia::PlatformCanvas canvas;
-
-  // Paint |view| into |canvas|.
-  if (!PaintViewIntoCanvas(view, canvas))
-    return false;
-
-  skia::BitmapPlatformDevice& device =
-      static_cast<skia::BitmapPlatformDevice&>(canvas.getTopPlatformDevice());
-
-  const SkBitmap& src_bmp = device.accessBitmap(false);
-
-  SkRect dest_rect = { 0, 0, SkIntToScalar(w), SkIntToScalar(h) };
-  float dest_aspect = dest_rect.width() / dest_rect.height();
-
-  // Get the src rect so that we can preserve the aspect ratio while filling
-  // the destination.
-  SkIRect src_rect;
-  if (src_bmp.width() < dest_rect.width() ||
-      src_bmp.height() < dest_rect.height()) {
-    // Source image is smaller: we clip the part of source image within the
-    // dest rect, and then stretch it to fill the dest rect. We don't respect
-    // the aspect ratio in this case.
-    src_rect.set(0, 0, static_cast<S16CPU>(dest_rect.width()),
-                 static_cast<S16CPU>(dest_rect.height()));
-    score->good_clipping = false;
-  } else {
-    float src_aspect = static_cast<float>(src_bmp.width()) / src_bmp.height();
-    if (src_aspect > dest_aspect) {
-      // Wider than tall, clip horizontally: we center the smaller thumbnail in
-      // the wider screen.
-      S16CPU new_width = static_cast<S16CPU>(src_bmp.height() * dest_aspect);
-      S16CPU x_offset = (src_bmp.width() - new_width) / 2;
-      src_rect.set(x_offset, 0, new_width + x_offset, src_bmp.height());
-      score->good_clipping = false;
-    } else {
-      src_rect.set(0, 0, src_bmp.width(),
-                   static_cast<S16CPU>(src_bmp.width() / dest_aspect));
-      score->good_clipping = true;
-    }
-  }
-
-  score->at_top = (view->mainFrame()->scrollOffset().height == 0);
-
-  SkBitmap subset;
-  device.accessBitmap(false).extractSubset(&subset, src_rect);
-
-  // First do a fast downsample by powers of two to get close to the final size.
-  SkBitmap downsampled_subset =
-      SkBitmapOperations::DownsampleByTwoUntilSize(subset, w, h);
-
-  // Do a high-quality resize from the downscaled size to the final size.
-  *thumbnail = skia::ImageOperations::Resize(
-      downsampled_subset, skia::ImageOperations::RESIZE_LANCZOS3, w, h);
-
-  score->boring_score = CalculateBoringScore(thumbnail);
-
-  HISTOGRAM_TIMES("Renderer4.Thumbnail",
-                  base::TimeTicks::Now() - beginning_time);
-
-  return true;
-}
-
 bool RenderView::CaptureSnapshot(WebView* view, SkBitmap* snapshot) {
   base::TimeTicks beginning_time = base::TimeTicks::Now();
 
   skia::PlatformCanvas canvas;
   if (!PaintViewIntoCanvas(view, canvas))
     return false;
 
   skia::BitmapPlatformDevice& device =
       static_cast<skia::BitmapPlatformDevice&>(canvas.getTopPlatformDevice());
 
@@ skipping 3724 matching lines @@
   // Notify the pepper plugins that we started painting.
   pepper_delegate_.ViewInitiatedPaint();
 
   // Notify any "old-style" pepper plugins that we started painting. This is
   // used for internal bookkeeping only, so we know that the set can not change
   // under us.
   for (std::set<WebPluginDelegatePepper*>::iterator i =
            current_oldstyle_pepper_plugins_.begin();
        i != current_oldstyle_pepper_plugins_.end(); ++i)
     (*i)->RenderViewInitiatedPaint();
+
+  WebKit::WebSize scroll_offset = webview()->mainFrame()->scrollOffset();
+  gfx::Size gfx_scroll_offset(scroll_offset.width, scroll_offset.height);
+  Send(new ViewHostMsg_UpdateScrollOffset(routing_id_, gfx_scroll_offset));

[brettw, 2011/01/18 18:25:42]

If you need something in RenderWidget, you can just make a virtual function that
RenderView provides an implementation for. An example is
GetBitmapForOptimizedPluginPaint. Potentially the default one could just return
Size(0, 0) and then RenderView would provide the "real" one. Would this allow
you to implement this more cleanly?

[satorux1, 2011/01/19 01:36:36]

Sounds like a good idea. I'll give it a try.

 }
 
 void RenderView::DidFlushPaint() {
   // Notify any pepper plugins that we painted. This will call into the plugin,
   // and we it may ask to close itself as a result. This will, in turn, modify
   // our set, possibly invalidating the iterator. So we iterate on a copy that
   // won't change out from under us.
   pepper_delegate_.ViewFlushedPaint();
 
   // Notify any old-style pepper plugins that we painted. This will call into
@@ skipping 582 matching lines @@
   if (cmd == kJavaScriptStressTestSetStressRunType) {
     v8::Testing::SetStressRunType(static_cast<v8::Testing::StressType>(param));
   } else if (cmd == kJavaScriptStressTestPrepareStressRun) {
     v8::Testing::PrepareStressRun(param);
   }
 }
 
 void RenderView::OnContextMenuClosed() {
   context_menu_node_.reset();
 }