Fix a bug that broke the timezone setting.

Fix a bug that broke the timezone setting.

The issue was probably introduced by 
http://src.chromium.org/viewvc/chrome?view=rev&revision=71284
that made undefined dataType to be an error.

BUG=chromium-os:10878
TEST=manually on the netbook

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71624

[kochi, 2011-01-17 10:28:21]

LGTM

Please CC this review to those who introduced the 'dataType'
attribute in pref_ui.js so that they can be aware of it?

ChromeOS have been broken too many times by changes which are
for DOM UI, not specific to non-ChromeOS.

Any infrastructural change for options UI resources should be
tested for both Chrome and ChromeOS, we want some way to force it...

[satorux1, 2011-01-17 10:47:33]

+estade just FYI.

dataType attribute was introduced a while back, but undefined dataType was
treated as string until 
http://src.chromium.org/viewvc/chrome?view=rev&revision=71284

http://codereview.chromium.org/6286002/ will fix other broken settings.



On 2011/01/17 10:28:21, Takayoshi Kochi wrote:
> LGTM
> 
> Please CC this review to those who introduced the 'dataType'
> attribute in pref_ui.js so that they can be aware of it?
> 
> ChromeOS have been broken too many times by changes which are
> for DOM UI, not specific to non-ChromeOS.
> 
> Any infrastructural change for options UI resources should be
> tested for both Chrome and ChromeOS, we want some way to force it...

[Evan Stade, 2011-01-18 20:50:09]

thanks for making these updates.

-- Evan Stade



On Mon, Jan 17, 2011 at 2:47 AM,  <satorux@chromium.org> wrote:
> +estade just FYI.
>
> dataType attribute was introduced a while back, but undefined dataType was
> treated as string until
> http://src.chromium.org/viewvc/chrome?view=rev&revision=71284
>
> http://codereview.chromium.org/6286002/ will fix other broken settings.
>
>
>
> On 2011/01/17 10:28:21, Takayoshi Kochi wrote:
>>
>> LGTM
>
>> Please CC this review to those who introduced the 'dataType'
>> attribute in pref_ui.js so that they can be aware of it?
>
>> ChromeOS have been broken too many times by changes which are
>> for DOM UI, not specific to non-ChromeOS.
>
>> Any infrastructural change for options UI resources should be
>> tested for both Chrome and ChromeOS, we want some way to force it...
>
>
>
> http://codereview.chromium.org/6246005/
>