Issue 6246004: Fix bug when the scanner does a pushback at the end of input.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6246004: Fix bug when the scanner does a pushback at the end of input. (Closed)

Created:
9 years, 11 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, Rico

CC:
v8-dev

Visibility:
Public.

Description

Fix bug when the scanner does a pushback at the end of input. We don't advance the input cursor past the end of input, so we shouldn't decrease it when we pushback the kEndOfInput marker.

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -13 lines)			Patch
M	src/preparser-api.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/scanner.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/scanner.cc	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	src/scanner-base.h	View	2 chunks	+7 lines, -6 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/6246004/diff/1/src/scanner-base.h File src/scanner-base.h (right): http://codereview.chromium.org/6246004/diff/1/src/scanner-base.h#newcode100 src/scanner-base.h:100: // Pushes back the most recently read UC16 ...

9 years, 11 months ago (2011-01-14 10:37:16 UTC) #2

Lasse Reichstein

9 years, 11 months ago (2011-01-14 10:49:03 UTC) #3

http://codereview.chromium.org/6246004/diff/1/src/scanner-base.h
File src/scanner-base.h (right):

http://codereview.chromium.org/6246004/diff/1/src/scanner-base.h#newcode100
src/scanner-base.h:100: // Pushes back the most recently read UC16 character (or
negative
The kEndOfInput name isn't publicly visible. All we guarantee is that we return
negative for end-of-input.
The constant is used internally only to give meaningful name to the value
returned in those case.

Expand Messages | Collapse Messages