Issue 6246003: Adding gyp file for all of the experimental extensions (currently i18n-extens...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6246003: Adding gyp file for all of the experimental extensions (currently i18n-extens... (Closed)

Created:
9 years, 11 months ago by Nebojša Ćirić

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Adding gyp file for all of the experimental extensions (currently i18n-extension only). Embedder should define icu_src_path to point to their copy of ICU library. Change to chromium/src/build/common.gypi will add this for chrome and webkit projects. Landed in bleeding_edge r6296.

Patch Set 1 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -0 lines)			Patch
	A	src/extensions/experimental/experimental.gyp	View		1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nebojša Ćirić

Sorry it took so long, but gyp is not the easiest thing to handle :).

9 years, 11 months ago (2011-01-13 02:08:46 UTC) #1

Mads Ager (chromium)

9 years, 11 months ago (2011-01-13 09:42:16 UTC) #2

LGTM

If/when we get more experimental extensions we might want to split the gyp stuff
into multiple files but this is fine for now. Thanks!

Expand Messages | Collapse Messages