Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6246001: Move app/key* to ui/base/keycodes/* (Closed)

Created:
9 years, 11 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
CC:
chromium-reviews, nkostylev+cc_chromium.org, Alpha Left Google, Sergey Ulanov, Ilya Sherman, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, dmac, pam+watch_chromium.org, awong, garykac, Paweł Hajdan Jr., darin-cc_chromium.org, James Hawkins, davemoore+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Move app/key* to ui/base/keycodes/* BUG=none TEST=none TBR=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3162 lines, -3185 lines) Patch
M app/app_base.gypi View 5 chunks +28 lines, -28 lines 0 comments Download
M app/event_synthesis_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M app/event_synthesis_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D app/keyboard_code_conversion.h View 1 chunk +0 lines, -22 lines 0 comments Download
D app/keyboard_code_conversion.cc View 1 chunk +0 lines, -296 lines 0 comments Download
D app/keyboard_code_conversion_gtk.h View 1 chunk +0 lines, -50 lines 0 comments Download
D app/keyboard_code_conversion_gtk.cc View 1 chunk +0 lines, -617 lines 0 comments Download
D app/keyboard_code_conversion_mac.h View 1 chunk +0 lines, -34 lines 0 comments Download
D app/keyboard_code_conversion_mac.mm View 1 chunk +0 lines, -293 lines 0 comments Download
D app/keyboard_code_conversion_unittest.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D app/keyboard_code_conversion_win.h View 1 chunk +0 lines, -19 lines 0 comments Download
D app/keyboard_code_conversion_win.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D app/keyboard_code_conversion_x.h View 1 chunk +0 lines, -18 lines 0 comments Download
D app/keyboard_code_conversion_x.cc View 1 chunk +0 lines, -281 lines 0 comments Download
D app/keyboard_codes.h View 1 chunk +0 lines, -17 lines 0 comments Download
D app/keyboard_codes_posix.h View 1 chunk +0 lines, -210 lines 0 comments Download
D app/keyboard_codes_win.h View 1 chunk +0 lines, -186 lines 0 comments Download
M app/menus/accelerator.h View 4 chunks +5 lines, -5 lines 0 comments Download
M app/menus/accelerator_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M app/menus/accelerator_gtk.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc View 28 chunks +60 lines, -60 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/ui_controls.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/ui_controls_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/ui_controls_mac.mm View 8 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/automation/ui_controls_win.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 28 chunks +38 lines, -38 lines 0 comments Download
M chrome/browser/chromeos/login/captcha_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_view.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/guest_user_view.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/new_user_view.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_lock_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_input_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/html_dialog_window_controller.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table_gtk.cc View 2 chunks +99 lines, -99 lines 0 comments Download
M chrome/browser/ui/views/accessible_pane_view.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/bookmark_bar_view_test.cc View 12 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/bookmark_bubble_view.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/browser_keyboard_accessibility_test_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/download_item_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 6 chunks +28 lines, -28 lines 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/info_bubble.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/js_modal_dialog_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/keyword_editor_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/options/cookies_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/cookies_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/unhandled_keyboard_event_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/url_picker.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/automation_messages_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill_helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/password_autocomplete_manager.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/password_autocomplete_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/render_view_browsertest.cc View 4 chunks +25 lines, -25 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_tests.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_tests.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/test/automation/window_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/window_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/interactive_ui/keyboard_access_uitest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/test/interactive_ui/npapi_interactive_test.cc View 3 chunks +6 lines, -31 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui_test_utils.h View 6 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/ui_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/keymap.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/webdriver/keymap.cc View 1 chunk +89 lines, -89 lines 0 comments Download
M remoting/host/event_executor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/base/keycodes/keyboard_code_conversion.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_code_conversion.cc View 1 chunk +296 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_code_conversion_gtk.h View 1 chunk +50 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_code_conversion_gtk.cc View 1 chunk +617 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_code_conversion_mac.h View 1 chunk +35 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_code_conversion_mac.mm View 1 chunk +293 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_code_conversion_unittest.cc View 1 chunk +43 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_code_conversion_win.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_code_conversion_win.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_code_conversion_x.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_code_conversion_x.cc View 1 chunk +281 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_codes.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_codes_posix.h View 1 chunk +210 lines, -0 lines 0 comments Download
A ui/base/keycodes/keyboard_codes_win.h View 1 chunk +186 lines, -0 lines 0 comments Download
M views/accelerator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M views/accelerator.cc View 2 chunks +15 lines, -15 lines 0 comments Download
M views/controls/button/custom_button.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M views/controls/button/menu_button.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M views/controls/button/native_button.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/combobox/combobox.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/link.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M views/controls/menu/menu_controller.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M views/controls/menu/menu_win.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/native_menu_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/menu/native_menu_win.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M views/controls/native_control.h View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/native_control.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/scrollbar/bitmap_scroll_bar.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar_gtk.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar_win.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M views/controls/tabbed_pane/tabbed_pane.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M views/controls/table/group_table_view.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/table/group_table_view.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M views/controls/table/native_table_win.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/table/native_table_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/table/table_view.h View 2 chunks +3 lines, -2 lines 0 comments Download
M views/controls/table/table_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/table/table_view_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/textfield/native_textfield_views.cc View 4 chunks +78 lines, -78 lines 0 comments Download
M views/controls/textfield/native_textfield_views_unittest.cc View 10 chunks +59 lines, -59 lines 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M views/controls/textfield/textfield.h View 1 chunk +5 lines, -5 lines 0 comments Download
M views/controls/textfield/textfield.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M views/controls/tree/tree_view.h View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/tree/tree_view.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M views/event.h View 4 chunks +5 lines, -5 lines 0 comments Download
M views/event.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/event_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/event_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/event_x.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/examples/table2_example.h View 1 chunk +1 line, -1 line 0 comments Download
M views/examples/table_example.h View 1 chunk +1 line, -1 line 0 comments Download
M views/focus/accelerator_handler_gtk_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M views/focus/accelerator_handler_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/focus/focus_manager.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M views/focus/focus_manager_unittest.cc View 9 chunks +45 lines, -45 lines 0 comments Download
M views/view_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M views/widget/root_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/widget/widget_gtk.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M views/widget/widget_win.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M views/window/dialog_client_view.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M views/window/window_win.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M webkit/support/webkit_support.h View 2 chunks +14 lines, -14 lines 0 comments Download
M webkit/tools/test_shell/event_sending_controller.cc View 6 chunks +21 lines, -21 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698