Add more cbuild options, revise configs

Add more cbuild options, revise configs

BUG=chromium-os:11229
TEST=Local, unittests

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=38a6657

[dgarrett, 2011-01-27 00:31:18]

The change I'm most afraid of is that I've mistakenly changed a config option
for an existing build.

[sosa, 2011-01-27 00:50:55]

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py#newc...
bin/cbuildbot_config.py:31: autotests -- Run autotests in build_package
Build autotests in build_package (not run)

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py#newc...
bin/cbuildbot_config.py:38: test_mod -- Create a test mod image.
Why are these currently set at all?  Don't these only affect full builders (not
bin's)

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py#newc...
bin/cbuildbot_config.py:44: # 'board' No default value
Why not purposefully set to None instead of comment.

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py#newc...
bin/cbuildbot_config.py:117: 'uprev' : True,
Does not run autotests currently (doesn't work) though it might work ...

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py#newc...
bin/cbuildbot_config.py:125: 'uprev' : True,
autotest  settings are wrong

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py#newc...
bin/cbuildbot_config.py:135: 'board' : 'arm-generic',
autotest settings are wrong

[dgarrett, 2011-01-27 01:35:02]

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py#newc...
bin/cbuildbot_config.py:31: autotests -- Run autotests in build_package
On 2011/01/27 00:50:55, sosa wrote:
> Build autotests in build_package (not run)

Um... how do they get run in cbuild? Perhaps the same flag should control both
building and running them.

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py#newc...
bin/cbuildbot_config.py:38: test_mod -- Create a test mod image.
On 2011/01/27 00:50:55, sosa wrote:
> Why are these currently set at all?  Don't these only affect full builders
(not
> bin's)

Ah, I made a mistake. The only affect builds that are archived. They are enabled
for everything but arm right now, and I'd like to make these options go away
when they work properly for arm.

I'll rearrange and fix docs to make this clear.

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py#newc...
bin/cbuildbot_config.py:44: # 'board' No default value
On 2011/01/27 00:50:55, sosa wrote:
> Why not purposefully set to None instead of comment.

For hostname, I know of a case where not setting it will lead to a python error,
where a None will get passed along in a confusing way.

Better checking for valid config's is the best answer, but I really didn't want
to go there yet.

[dgarrett, 2011-01-27 01:43:19]

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/6245013/diff/5001/bin/cbuildbot_config.py#newc...
bin/cbuildbot_config.py:31: autotests -- Run autotests in build_package
Is it fair to say that autotests should be true if "tests" or "unittests" is
true (and no --notests)?

[dgarrett, 2011-01-27 19:41:46]

On 2011/01/27 19:38:35, dgarrett wrote:

PTAL with the test flag changes. It's building locally, and I plan to push it
when it's done.

[sosa, 2011-01-27 19:48:55]

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot.py#newcode367
bin/cbuildbot.py:367: def _Build(buildroot, emptytree, autotest=True,
usepkg=True):
maybe rename autotest to build_autotest.

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:30: vm_tests -- Runs the smoke suite and au test harness
in a qemu-based VM using KVM.
80 chars

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:32: usepkg -- Use binary packages to bootstrap, when
possible
i'd be more specific ... pass --usepkg to emerge.

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:80: config['x86-mario-pre-flight-queue'] = {
Should be .update?

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:89: config['x86-mario-pre-flight-branch'] = {
Should be .update?

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:98: config['x86-agz-bin'] = {
Should be .update?

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:106: config['x86-dogfood-bin'] = {
Should be .update?

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:114: config['x86-pineview-bin'] = {
Should be .update?

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:122: config['arm-tegra2-bin'] = {
Should be .update?

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:133: config['arm-generic-bin'] = {
Should be .update?

[dgarrett, 2011-01-27 21:05:52]

Good catches, ESPECIALLY the missing .update()s.

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:30: vm_tests -- Runs the smoke suite and au test harness
in a qemu-based VM using KVM.
On 2011/01/27 19:48:56, sosa wrote:
> 80 chars

Done.

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:80: config['x86-mario-pre-flight-queue'] = {
On 2011/01/27 19:48:56, sosa wrote:
> Should be .update?

Done.

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:89: config['x86-mario-pre-flight-branch'] = {
On 2011/01/27 19:48:56, sosa wrote:
> Should be .update?

Done.

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:98: config['x86-agz-bin'] = {
On 2011/01/27 19:48:56, sosa wrote:
> Should be .update?

Done.

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:106: config['x86-dogfood-bin'] = {
On 2011/01/27 19:48:56, sosa wrote:
> Should be .update?

Done.

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:114: config['x86-pineview-bin'] = {
On 2011/01/27 19:48:56, sosa wrote:
> Should be .update?

Done.

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:122: config['arm-tegra2-bin'] = {
On 2011/01/27 19:48:56, sosa wrote:
> Should be .update?

Done.

http://codereview.chromium.org/6245013/diff/12001/bin/cbuildbot_config.py#new...
bin/cbuildbot_config.py:133: config['arm-generic-bin'] = {
On 2011/01/27 19:48:56, sosa wrote:
> Should be .update?

Done.

[sosa, 2011-01-27 21:21:15]

LGTM