Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 6245012: Removes different instant behaviors that are no longer used. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update tests Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 20 matching lines...) Expand all
31 namespace { 31 namespace {
32 32
33 const unsigned kOsAll = kOsMac | kOsWin | kOsLinux | kOsCrOS; 33 const unsigned kOsAll = kOsMac | kOsWin | kOsLinux | kOsCrOS;
34 34
35 // Names for former Chrome OS Labs experiments, shared with prefs migration 35 // Names for former Chrome OS Labs experiments, shared with prefs migration
36 // code. 36 // code.
37 const char kMediaPlayerExperimentName[] = "media-player"; 37 const char kMediaPlayerExperimentName[] = "media-player";
38 const char kAdvancedFileSystemExperimentName[] = "advanced-file-system"; 38 const char kAdvancedFileSystemExperimentName[] = "advanced-file-system";
39 const char kVerticalTabsExperimentName[] = "vertical-tabs"; 39 const char kVerticalTabsExperimentName[] = "vertical-tabs";
40 40
41 // If adding a new choice, add it to the end of the list.
42 const Experiment::Choice kInstantChoices[] = {
43 { IDS_FLAGS_INSTANT_TYPE_VERBATIM, switches::kEnableVerbatimInstant },
44 { IDS_FLAGS_INSTANT_TYPE_PREDICTIVE, switches::kEnablePredictiveInstant },
45 { IDS_FLAGS_INSTANT_TYPE_PREDICTIVE_NO_AUTO_COMPLETE,
46 switches::kEnablePredictiveNoAutoCompleteInstant
47 },
48 };
49
50 // RECORDING USER METRICS FOR FLAGS: 41 // RECORDING USER METRICS FOR FLAGS:
51 // ----------------------------------------------------------------------------- 42 // -----------------------------------------------------------------------------
52 // The first line of the experiment is the internal name. If you'd like to 43 // The first line of the experiment is the internal name. If you'd like to
53 // gather statistics about the usage of your flag, you should append a marker 44 // gather statistics about the usage of your flag, you should append a marker
54 // comment to the end of the feature name, like so: 45 // comment to the end of the feature name, like so:
55 // "my-special-feature", // FLAGS:RECORD_UMA 46 // "my-special-feature", // FLAGS:RECORD_UMA
56 // 47 //
57 // After doing that, run //chrome/tools/extract_actions.py (see instructions at 48 // After doing that, run //chrome/tools/extract_actions.py (see instructions at
58 // the top of that file for details) to update the chromeactions.txt file, which 49 // the top of that file for details) to update the chromeactions.txt file, which
59 // will enable UMA to record your feature flag. 50 // will enable UMA to record your feature flag.
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 SINGLE_VALUE_TYPE(switches::kNoPings) 235 SINGLE_VALUE_TYPE(switches::kNoPings)
245 }, 236 },
246 { 237 {
247 "experimental-location-features", // FLAGS:RECORD_UMA 238 "experimental-location-features", // FLAGS:RECORD_UMA
248 IDS_FLAGS_EXPERIMENTAL_LOCATION_FEATURES_NAME, 239 IDS_FLAGS_EXPERIMENTAL_LOCATION_FEATURES_NAME,
249 IDS_FLAGS_EXPERIMENTAL_LOCATION_FEATURES_DESCRIPTION, 240 IDS_FLAGS_EXPERIMENTAL_LOCATION_FEATURES_DESCRIPTION,
250 kOsMac | kOsWin | kOsLinux, // Currently does nothing on CrOS. 241 kOsMac | kOsWin | kOsLinux, // Currently does nothing on CrOS.
251 SINGLE_VALUE_TYPE(switches::kExperimentalLocationFeatures) 242 SINGLE_VALUE_TYPE(switches::kExperimentalLocationFeatures)
252 }, 243 },
253 { 244 {
254 "instant-type", // FLAGS:RECORD_UMA
255 IDS_FLAGS_INSTANT_TYPE_NAME,
256 IDS_FLAGS_INSTANT_TYPE_DESCRIPTION,
257 kOsWin,
258 MULTI_VALUE_TYPE(kInstantChoices)
259 },
260 {
261 "instant-autocomplete-immediately", // FLAGS:RECORD_UMA 245 "instant-autocomplete-immediately", // FLAGS:RECORD_UMA
262 IDS_FLAGS_INSTANT_AUTOCOMPLETE_IMMEDIATELY_NAME, 246 IDS_FLAGS_INSTANT_AUTOCOMPLETE_IMMEDIATELY_NAME,
263 IDS_FLAGS_INSTANT_AUTOCOMPLETE_IMMEDIATELY_DESCRIPTION, 247 IDS_FLAGS_INSTANT_AUTOCOMPLETE_IMMEDIATELY_DESCRIPTION,
264 kOsWin | kOsLinux, 248 kOsWin | kOsLinux,
265 SINGLE_VALUE_TYPE(switches::kInstantAutocompleteImmediately) 249 SINGLE_VALUE_TYPE(switches::kInstantAutocompleteImmediately)
266 }, 250 },
267 { 251 {
268 "block-reading-third-party-cookies", 252 "block-reading-third-party-cookies",
269 IDS_FLAGS_BLOCK_ALL_THIRD_PARTY_COOKIES_NAME, 253 IDS_FLAGS_BLOCK_ALL_THIRD_PARTY_COOKIES_NAME,
270 IDS_FLAGS_BLOCK_ALL_THIRD_PARTY_COOKIES_DESCRIPTION, 254 IDS_FLAGS_BLOCK_ALL_THIRD_PARTY_COOKIES_DESCRIPTION,
(...skipping 400 matching lines...) Expand 10 before | Expand all | Expand 10 after
671 } 655 }
672 656
673 const Experiment* GetExperiments(size_t* count) { 657 const Experiment* GetExperiments(size_t* count) {
674 *count = num_experiments; 658 *count = num_experiments;
675 return experiments; 659 return experiments;
676 } 660 }
677 661
678 } // namespace testing 662 } // namespace testing
679 663
680 } // namespace about_flags 664 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698