Issue 6245005: Code to send diagnostic messages about cloud print proxy. Currently diagnosti...

Issue 6245005: Code to send diagnostic messages about cloud print proxy. Currently diagnosti... (Closed)

Created:
9 years, 11 months ago by sanjeevr

Modified:
9 years, 7 months ago

Reviewers:
gene, gene1, Scott Byer

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Code to send diagnostic messages about cloud print proxy. Currently diagnostic messages are sent if the print system fails to initialize (this can happen on Windows if the XPS Framework is not installed on XP) as well when printer registration fails because we could not get the capabilities for the printer. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72037

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Fixed build errors #

Patch Set 4 : Fixed build errors yet again #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+249 lines, -56 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/service/service_process_control.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/service/DEPS	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_consts.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_consts.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_helpers.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_helpers.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_helpers_unittest.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy.cc	View		3 chunks	+11 lines, -2 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy_backend.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy_backend.cc	View		12 chunks	+132 lines, -36 lines	2 comments	Download
M	chrome/service/cloud_print/print_system.h	View		2 chunks	+15 lines, -1 line	0 comments	Download
M	chrome/service/cloud_print/print_system_cups.cc	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_win.cc	View	1 2	4 chunks	+10 lines, -2 lines	0 comments	Download
M	chrome/service/service_process.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/service/service_process.cc	View		4 chunks	+31 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Scott Byer

LGTM, w/ nits http://codereview.chromium.org/6245005/diff/19019/chrome/service/cloud_print/cloud_print_proxy_backend.cc File chrome/service/cloud_print/cloud_print_proxy_backend.cc (right): http://codereview.chromium.org/6245005/diff/19019/chrome/service/cloud_print/cloud_print_proxy_backend.cc#newcode745 chrome/service/cloud_print/cloud_print_proxy_backend.cc:745: // Terminate the request body nit: ...

9 years, 11 months ago (2011-01-20 19:09:03 UTC) #2

gene1

9 years, 11 months ago (2011-01-20 19:44:04 UTC) #3

LGTM

On 2011/01/20 19:09:03, Scott Byer wrote:
> LGTM, w/ nits
> 
>
http://codereview.chromium.org/6245005/diff/19019/chrome/service/cloud_print/...
> File chrome/service/cloud_print/cloud_print_proxy_backend.cc (right):
> 
>
http://codereview.chromium.org/6245005/diff/19019/chrome/service/cloud_print/...
> chrome/service/cloud_print/cloud_print_proxy_backend.cc:745: // Terminate the
> request body
> nit: indentation
> 
>
http://codereview.chromium.org/6245005/diff/19019/chrome/service/cloud_print/...
> chrome/service/cloud_print/cloud_print_proxy_backend.cc:804:
> backend_->frontend_loop_->PostTask(FROM_HERE, NewRunnableMethod(this,
> nit: indentation clearer in HandleRegisterFailedStatusResponse

Expand Messages | Collapse Messages