Fixed initial rendering of toolbar.

Fixed initial rendering of toolbar.

IE will create empty properly rendered toolbar instead of white box. Then chrome frame will be placed above.

BUG=none
TEST=none

[Cindy Lau, 2011-01-13 00:16:22]

LGTM, but you should probably wait for Siggi to review.

[Vitaly Buka corp, 2011-01-13 02:42:53]

Sure.

On 2011/01/13 00:16:22, Cindy Lau wrote:
> LGTM, but you should probably wait for Siggi to review.

[Sigurður Ásgeirsson, 2011-01-13 14:42:55]

lgtm with a couple of nits.

http://codereview.chromium.org/6245001/diff/1/ceee/ie/plugin/toolband/tool_ba...
File ceee/ie/plugin/toolband/tool_band.cc (right):

http://codereview.chromium.org/6245001/diff/1/ceee/ie/plugin/toolband/tool_ba...
ceee/ie/plugin/toolband/tool_band.cc:308: // for painting toolband background
while chrome frame is hidden.
nice, thanks. Do you prefer this to specifying a style class to the
CWindowImpl<>?

http://codereview.chromium.org/6245001/diff/1/ceee/ie/plugin/toolband/tool_ba...
ceee/ie/plugin/toolband/tool_band.cc:358:
chrome_frame_container_window_.Create(m_hWnd, NULL, NULL, WS_CHILD);
Please retrieve the result and error check it.

http://codereview.chromium.org/6245001/diff/1/ceee/ie/plugin/toolband/tool_ba...
File ceee/ie/plugin/toolband/tool_band.h (right):

http://codereview.chromium.org/6245001/diff/1/ceee/ie/plugin/toolband/tool_ba...
ceee/ie/plugin/toolband/tool_band.h:58: DECLARE_WND_SUPERCLASS(NULL,
TOOLBARCLASSNAME)
Why do we want this class name? Can you add a quick comment?

[Vitaly Buka (NO REVIEWS), 2011-01-14 00:06:30]

http://codereview.chromium.org/6245001/diff/1/ceee/ie/plugin/toolband/tool_ba...
File ceee/ie/plugin/toolband/tool_band.cc (right):

http://codereview.chromium.org/6245001/diff/1/ceee/ie/plugin/toolband/tool_ba...
ceee/ie/plugin/toolband/tool_band.cc:308: // for painting toolband background
while chrome frame is hidden.
On 2011/01/13 14:42:55, Ruðrugis wrote:
> nice, thanks. Do you prefer this to specifying a style class to the
> CWindowImpl<>?

Done.

http://codereview.chromium.org/6245001/diff/1/ceee/ie/plugin/toolband/tool_ba...
ceee/ie/plugin/toolband/tool_band.cc:358:
chrome_frame_container_window_.Create(m_hWnd, NULL, NULL, WS_CHILD);
On 2011/01/13 14:42:55, Ruðrugis wrote:
> Please retrieve the result and error check it.

Done.

http://codereview.chromium.org/6245001/diff/1/ceee/ie/plugin/toolband/tool_ba...
File ceee/ie/plugin/toolband/tool_band.h (right):

http://codereview.chromium.org/6245001/diff/1/ceee/ie/plugin/toolband/tool_ba...
ceee/ie/plugin/toolband/tool_band.h:58: DECLARE_WND_SUPERCLASS(NULL,
TOOLBARCLASSNAME)
On 2011/01/13 14:42:55, Ruðrugis wrote:
> Why do we want this class name? Can you add a quick comment?

Done.

[Sigurður Ásgeirsson, 2011-01-14 14:00:43]

lgtm++

http://codereview.chromium.org/6245001/diff/23001/ceee/ie/plugin/toolband/too...
File ceee/ie/plugin/toolband/tool_band.h (right):

http://codereview.chromium.org/6245001/diff/23001/ceee/ie/plugin/toolband/too...
ceee/ie/plugin/toolband/tool_band.h:53: // WS_CHILD | WS_VISIBLE |
TBSTYLE_TRANSPARENT | CCS_NODIVIDER are critical
one last nit: can I ask you to move this to a typedef, e.g. 
typedef ... 
  ToolbandWindowImpl;

or some such for readability?