Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issue 6244003: crosutils/make_factory_package.sh: Support relative path (Closed)

Created:
9 years, 11 months ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

crosutils/make_factory_package.sh: Support relative path Since there's a pushd call when building images, we have to first retrieve the complete (full/absolute) path of target disk image. BUG=chromium-os:10706 TEST=make_factory_package.sh \ --factory ../build/images/x86-mario/latest/factory_image.bin \ --release ../build/images/x86-mario/latest/chromiumos_image.bin \ --diskimg blah_relative.bin Change-Id: I02e2edb0f76b724337a82dd400297877681bc338 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c584cf0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M make_factory_package.sh View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Hung-Te
9 years, 11 months ago (2011-01-13 06:30:24 UTC) #1
Nick Sanders
http://codereview.chromium.org/6244003/diff/1/make_factory_package.sh File make_factory_package.sh (right): http://codereview.chromium.org/6244003/diff/1/make_factory_package.sh#newcode89 make_factory_package.sh:89: local outdev="$(readlink -f "$FLAGS_diskimg")" I don't think this will ...
9 years, 11 months ago (2011-01-13 06:54:07 UTC) #2
Hung-Te
http://codereview.chromium.org/6244003/diff/1/make_factory_package.sh File make_factory_package.sh (right): http://codereview.chromium.org/6244003/diff/1/make_factory_package.sh#newcode89 make_factory_package.sh:89: local outdev="$(readlink -f "$FLAGS_diskimg")" On 2011/01/13 06:54:08, Nick Sanders ...
9 years, 11 months ago (2011-01-13 07:05:50 UTC) #3
Nick Sanders
9 years, 11 months ago (2011-01-13 07:28:14 UTC) #4
>   Right, but readlink -f reports full path.

Ah, you're right. 

LGTM

Powered by Google App Engine
This is Rietveld 408576698