Add LegacyContentSettingsProvider Interface.

Add ContentSettingsProvider Interface.

BUG=TBA
TEST=TAB

[markusheintz_, 2011-01-26 14:21:04]

This would be a real legacy interface that should allow copying code from the
HostContentSettingsMap to ContentSettingsProvider. 

So we could shape a better ContentSettingsProvider API while making progress on
moving code out of HCSM

[Bernhard Bauer, 2011-01-26 14:50:47]

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_provider.h (right):

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_provider.h:15: #include
"googleurl/src/gurl.h"
Forward-declare GURL?

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_provider.h:48: 
Remove blank line.

Also, you should add a virtual destructor.

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_provider.h:89: virtual
ContentSettings GetNonDefaultContentSettings(const GURL& url) const = 0;
80 cols

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_provider.h:100: const
std::string& resource_identifier,
Methinks your editor is indent-technically challenged. Align parameters plz.

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_provider.h:135: 
Remove blank line

[markusheintz_, 2011-01-26 16:27:47]

Fixed nits and lints. Please wait with any further review on this. Unit any more
new code appears here.

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_provider.h (right):

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_provider.h:15: #include
"googleurl/src/gurl.h"
On 2011/01/26 14:50:47, Bernhard Bauer wrote:
> Forward-declare GURL?

Done.

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_provider.h:48: 
On 2011/01/26 14:50:47, Bernhard Bauer wrote:
> Remove blank line.
> 
> Also, you should add a virtual destructor.

Done.

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_provider.h:89: virtual
ContentSettings GetNonDefaultContentSettings(const GURL& url) const = 0;
On 2011/01/26 14:50:47, Bernhard Bauer wrote:
> 80 cols

Done.

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_provider.h:100: const
std::string& resource_identifier,
On 2011/01/26 14:50:47, Bernhard Bauer wrote:
> Methinks your editor is indent-technically challenged. Align parameters plz.

Done.

http://codereview.chromium.org/6242013/diff/3001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_provider.h:135: 
On 2011/01/26 14:50:47, Bernhard Bauer wrote:
> Remove blank line

Done.