Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: chrome/browser/renderer_host/browser_render_process_host.cc

Issue 6242010: Refactor away most of ExtensionRendererInfo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove more deadness Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/browser_render_process_host.cc
diff --git a/chrome/browser/renderer_host/browser_render_process_host.cc b/chrome/browser/renderer_host/browser_render_process_host.cc
index 11398c3bd06d7934f4eb60f2fcddf1bbdc0426c6..f1e9cb5520e60b0bda4ba51123f66d6a9ef56936 100644
--- a/chrome/browser/renderer_host/browser_render_process_host.cc
+++ b/chrome/browser/renderer_host/browser_render_process_host.cc
@@ -827,27 +827,10 @@ void BrowserRenderProcessHost::SendExtensionInfo() {
ExtensionService* service = profile()->GetExtensionService();
if (!service)
return;
- ViewMsg_ExtensionsUpdated_Params params;
for (size_t i = 0; i < service->extensions()->size(); ++i) {
- const Extension* extension = service->extensions()->at(i);
- ViewMsg_ExtensionRendererInfo info;
- info.id = extension->id();
- info.web_extent = extension->web_extent();
- info.name = extension->name();
- info.location = extension->location();
- info.allowed_to_execute_script_everywhere =
- extension->CanExecuteScriptEverywhere();
- info.host_permissions = extension->host_permissions();
-
- // The icon in the page is 96px. We'd rather not scale up, so use 128.
- info.icon_url = extension->GetIconURL(Extension::EXTENSION_ICON_LARGE,
- ExtensionIconSet::MATCH_EXACTLY);
- if (info.icon_url.is_empty())
- info.icon_url = GURL("chrome://theme/IDR_APP_DEFAULT_ICON");
- params.extensions.push_back(info);
+ Send(new ViewMsg_ExtensionLoaded(
+ ViewMsg_ExtensionLoaded_Params(service->extensions()->at(i))));
}
-
- Send(new ViewMsg_ExtensionsUpdated(params));
}
bool BrowserRenderProcessHost::FastShutdownIfPossible() {
@@ -1125,9 +1108,15 @@ void BrowserRenderProcessHost::Observe(NotificationType type,
}
break;
}
- case NotificationType::EXTENSION_LOADED:
+ case NotificationType::EXTENSION_LOADED: {
+ Send(new ViewMsg_ExtensionLoaded(
+ ViewMsg_ExtensionLoaded_Params(
+ Details<const Extension>(details).ptr())));
+ break;
+ }
case NotificationType::EXTENSION_UNLOADED: {
- SendExtensionInfo();
+ Send(new ViewMsg_ExtensionUnloaded(
+ Details<UnloadedExtensionInfo>(details).ptr()->extension->id()));
break;
}
case NotificationType::SPELLCHECK_HOST_REINITIALIZED: {

Powered by Google App Engine
This is Rietveld 408576698