Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: chrome/renderer/localized_error.cc

Issue 6242010: Refactor away most of ExtensionRendererInfo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/localized_error.h ('k') | chrome/renderer/mock_render_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/localized_error.cc
diff --git a/chrome/renderer/localized_error.cc b/chrome/renderer/localized_error.cc
index 820f6a06b7f435ce08a3141aa220c70e28abc665..7b4ae31dd8ebc0d6899ec4811e5de1a7444acc44 100644
--- a/chrome/renderer/localized_error.cc
+++ b/chrome/renderer/localized_error.cc
@@ -516,10 +516,11 @@ void LocalizedError::GetFormRepostStrings(const GURL& display_url,
error_strings->Set("summary", summary);
}
-void LocalizedError::GetAppErrorStrings(const WebURLError& error,
- const GURL& display_url,
- const ExtensionRendererInfo* app,
- DictionaryValue* error_strings) {
+void LocalizedError::GetAppErrorStrings(
+ const WebURLError& error,
+ const GURL& display_url,
+ const Extension* app,
+ DictionaryValue* error_strings) {
DCHECK(app);
bool rtl = LocaleIsRTL();
@@ -534,7 +535,9 @@ void LocalizedError::GetAppErrorStrings(const WebURLError& error,
failed_url.c_str()));
error_strings->SetString("title", app->name());
- error_strings->SetString("icon", app->icon_url().spec());
+ error_strings->SetString("icon",
+ app->GetIconURL(Extension::EXTENSION_ICON_LARGE,
+ ExtensionIconSet::MATCH_SMALLER).spec());
error_strings->SetString("name", app->name());
error_strings->SetString("msg",
l10n_util::GetStringUTF16(IDS_ERRORPAGES_APP_WARNING));
« no previous file with comments | « chrome/renderer/localized_error.h ('k') | chrome/renderer/mock_render_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698