Refactor away most of ExtensionRendererInfo

chrome/renderer/extensions/chrome_app_bindings.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_app_bindings.h"
 
 #include "base/string16.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/renderer/extensions/bindings_utils.h"
 #include "chrome/renderer/extensions/extension_renderer_info.h"
@@ skipping 39 matching lines @@
     WebFrame* frame = WebFrame::frameForCurrentContext();
     if (!frame)
       return v8::Boolean::New(false);
 
     GURL url(frame->url());
     if (url.is_empty() ||
         !url.is_valid() ||
         !(url.SchemeIs("http") || url.SchemeIs("https")))
       return v8::Boolean::New(false);
 
-    bool has_web_extent = (ExtensionRendererInfo::GetByURL(url) != NULL);
+    bool has_web_extent =
+        RenderThread::current()->extensions()->GetByURL(url) != NULL;

[Matt Perry, 2011/01/24 20:08:34]

note that RenderThread::current() will be NULL in unit tests.

[Aaron Boodman, 2011/01/25 00:27:33]

Really? RenderThread::current() is backed by lazy TLS. It seems like it will
just create an instance.

[Matt Perry, 2011/01/25 00:45:54]

Oh, well maybe things have changed since I last looked. If unit tests don't
crash, then I guess this is fine.

     return v8::Boolean::New(has_web_extent);
   }
 
   static v8::Handle<v8::Value> Install(const v8::Arguments& args) {
     WebFrame* frame = WebFrame::frameForCurrentContext();
     RenderView* render_view = bindings_utils::GetRenderViewForCurrentContext();
     if (frame && render_view) {
       string16 error;
       if (!render_view->InstallWebApplicationUsingDefinitionFile(frame, &error))
         v8::ThrowException(v8::String::New(UTF16ToUTF8(error).c_str()));
     }
 
     return v8::Undefined();
   }
 };
 
 v8::Extension* ChromeAppExtension::Get() {
   return new ChromeAppExtensionWrapper();
 }
 
 }  // namespace extensions_v8