Refactor away most of ExtensionRendererInfo

chrome/common/render_messages_params.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_RENDER_MESSAGES_PARAMS_H_
 #define CHROME_COMMON_RENDER_MESSAGES_PARAMS_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 817 matching lines @@
   string16 title;
 
   // Default file name to select in the dialog.
   FilePath default_file_name;
 
   // A comma-separated MIME types such as "audio/*,text/plain", that is used
   // to restrict selectable files to such types.
   string16 accept_types;
 };
 
-struct ViewMsg_ExtensionRendererInfo {
-  ViewMsg_ExtensionRendererInfo();
-  ~ViewMsg_ExtensionRendererInfo();
+struct ViewMsg_ExtensionLoaded_Params {
+  ViewMsg_ExtensionLoaded_Params();
+  explicit ViewMsg_ExtensionLoaded_Params(
+      const ViewMsg_ExtensionLoaded_Params& other);

[Matt Perry, 2011/01/24 20:08:34]

when is this copy constructor used?

[Aaron Boodman, 2011/01/25 00:27:33]

It is used when ViewMsg_ExtensionLoaded is instantiated. It only happens on
older compilers, and I didn't dig into the IPC macro pile to figure exactly what
causes it. I added a comment explaining this.

[Matt Perry, 2011/01/25 00:45:54]

I see. In that case, maybe making a deep copy of the manifest is not needed. You
could do
  manifest(other.release())
instead, though manifest might need to be marked mutable.

+  explicit ViewMsg_ExtensionLoaded_Params(const Extension* extension);
 

[Elliot Glaysher, 2011/01/24 19:00:28]

dtor

[Aaron Boodman, 2011/01/25 00:27:33]

Done.

-  std::string id;
-  ExtensionExtent web_extent;
-  std::string name;
-  GURL icon_url;
+  // Creates a new extension from the data in this object.
+  scoped_refptr<Extension> ConvertToExtension() const;
+
+  // The subset of the extension manifest data we send to renderers.
+  scoped_ptr<DictionaryValue> manifest;
+
+  // The location the extension was installed from.
   Extension::Location location;
-  bool allowed_to_execute_script_everywhere;
-  std::vector<URLPattern> host_permissions;
-};
 
-struct ViewMsg_ExtensionsUpdated_Params {
-  ViewMsg_ExtensionsUpdated_Params();
-  ~ViewMsg_ExtensionsUpdated_Params();
-
-  // Describes the installed extension apps and the URLs they cover.
-  std::vector<ViewMsg_ExtensionRendererInfo> extensions;
+  // The path the extension was loaded from. This is used in the renderer only
+  // to generate the extension ID for extensions that are loaded unpacked.
+  FilePath path;
 };
 
 struct ViewMsg_DeviceOrientationUpdated_Params {
   ViewMsg_DeviceOrientationUpdated_Params();
   ~ViewMsg_DeviceOrientationUpdated_Params();
 
   // These fields have the same meaning as in device_orientation::Orientation.
   bool can_provide_alpha;
   double alpha;
   bool can_provide_beta;
@@ skipping 237 matching lines @@
 
 template<>
 struct ParamTraits<ViewHostMsg_RunFileChooser_Params> {
   typedef ViewHostMsg_RunFileChooser_Params param_type;
   static void Write(Message* m, const param_type& p);
   static bool Read(const Message* m, void** iter, param_type* p);
   static void Log(const param_type& p, std::string* l);
 };
 
 template <>
-struct ParamTraits<ViewMsg_ExtensionRendererInfo> {
-  typedef ViewMsg_ExtensionRendererInfo param_type;
+struct ParamTraits<ViewMsg_ExtensionLoaded_Params> {
+  typedef ViewMsg_ExtensionLoaded_Params param_type;
   static void Write(Message* m, const param_type& p);
   static bool Read(const Message* m, void** iter, param_type* p);
   static void Log(const param_type& p, std::string* l);
-};
-
-template <>
-struct ParamTraits<ViewMsg_ExtensionsUpdated_Params> {
-  typedef ViewMsg_ExtensionsUpdated_Params param_type;
-  static void Write(Message* m, const param_type& p);
-  static bool Read(const Message* m, void** iter, param_type* p);
-  static void Log(const param_type& p, std::string* l);
 };
 
 template <>
 struct ParamTraits<ViewMsg_DeviceOrientationUpdated_Params> {
   typedef ViewMsg_DeviceOrientationUpdated_Params param_type;
   static void Write(Message* m, const param_type& p);
   static bool Read(const Message* m, void** iter, param_type* p);
   static void Log(const param_type& p, std::string* l);
 };
 
@@ skipping 17 matching lines @@
 struct ParamTraits<ViewHostMsg_AccessibilityNotification_Params> {
   typedef ViewHostMsg_AccessibilityNotification_Params param_type;
   static void Write(Message* m, const param_type& p);
   static bool Read(const Message* m, void** iter, param_type* p);
   static void Log(const param_type& p, std::string* l);
 };
 
 }  // namespace IPC
 
 #endif  // CHROME_COMMON_RENDER_MESSAGES_PARAMS_H_