Refactor away most of ExtensionRendererInfo

chrome/browser/renderer_host/browser_render_process_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "chrome/browser/renderer_host/browser_render_process_host.h"
 
 #include <algorithm>
@@ skipping 617 matching lines @@
     command_line->AppendSwitch(switches::kDisable3DAPIs);
   }
 }
 
 void BrowserRenderProcessHost::PropagateBrowserCommandLineToRenderer(
     const CommandLine& browser_cmd,
     CommandLine* renderer_cmd) const {
   // Propagate the following switches to the renderer command line (along
   // with any associated values) if present in the browser command line.
   static const char* const kSwitchNames[] = {
+    switches::kAllowOutdatedPlugins,
+    switches::kAllowScriptingGallery,
+    switches::kAppsGalleryURL,
+    // We propagate the Chrome Frame command line here as well in case the
+    // renderer is not run in the sandbox.
+    switches::kChromeFrame,
+    switches::kDebugPrint,
+    switches::kDisable3DAPIs,
+    switches::kDisableAcceleratedCompositing,
+    switches::kDisableApplicationCache,
+    switches::kDisableAudio,
+    switches::kDisableBreakpad,
+    switches::kDisableDatabases,
+    switches::kDisableDesktopNotifications,
+    switches::kDisableDeviceOrientation,
+    // We need to propagate this flag to determine whether to make the
+    // WebGLArray constructors on the DOMWindow visible. This
+    // information is needed very early during bringup. We prefer to
+    // use the WebPreferences to set this flag on a page-by-page basis.
+    switches::kDisableExperimentalWebGL,
+    switches::kDisableFileSystem,
+    switches::kDisableGeolocation,
+    switches::kDisableGLSLTranslator,
+    switches::kDisableIndexedDatabase,
+    switches::kDisableLocalStorage,
+    switches::kDisableLogging,
+    switches::kDisableSeccompSandbox,
+    switches::kDisableSessionStorage,
+    switches::kDisableSharedWorkers,
+    switches::kDisableSpeechInput,
+    switches::kDisableWebSockets,
+    switches::kDomAutomationController,
+    switches::kDumpHistogramsOnExit,
+    switches::kEnableAcceleratedDecoding,
+    switches::kEnableBenchmarking,
+    switches::kEnableClickToPlay,
+    switches::kEnableCrxlessWebApps,
+    switches::kEnableDCHECK,
+    switches::kEnableExperimentalExtensionApis,
+    switches::kEnableInBrowserThumbnailing,
+    switches::kEnableLogging,
+    switches::kEnableNaCl,
+    switches::kEnableOpenMax,
+    switches::kEnablePepperTesting,
+    switches::kEnablePrintPreview,
+    switches::kEnableRemoting,
+    switches::kEnableResourceContentSettings,
+#if defined(OS_MACOSX)
+    // Allow this to be set when invoking the browser and relayed along.
+    switches::kEnableSandboxLogging,
+#endif
+    switches::kEnableSearchProviderApiV2,
+    switches::kEnableSeccompSandbox,
+    switches::kEnableStatsTable,
+    switches::kEnableTouch,
+    switches::kEnableVideoFullscreen,
+    switches::kEnableVideoLogging,
+    switches::kEnableWatchdog,
+    switches::kEnableWebAudio,
+    switches::kExperimentalSpellcheckerFeatures,
+    switches::kFullMemoryCrashReport,
+#if !defined (GOOGLE_CHROME_BUILD)
+    // These are unsupported and not fully tested modes, so don't enable them
+    // for official Google Chrome builds.
+    switches::kInProcessPlugins,
+#endif  // GOOGLE_CHROME_BUILD
+    switches::kInProcessWebGL,
+    switches::kInternalNaCl,
+    switches::kInternalPepper,
+    switches::kJavaScriptFlags,
+    switches::kLoggingLevel,
+    switches::kMemoryProfiling,
+    switches::kMessageLoopHistogrammer,
+    switches::kNewChromeUISecurityModel,
+    switches::kNoJsRandomness,
+    switches::kNoReferrers,
+    switches::kNoSandbox,
+    switches::kPlaybackMode,
+    switches::kPpapiOutOfProcess,
+    switches::kRecordMode,
+    switches::kRegisterPepperPlugins,
+    switches::kRemoteShellPort,
     switches::kRendererAssertTest,
 #if !defined(OFFICIAL_BUILD)
     switches::kRendererCheckFalseTest,
 #endif  // !defined(OFFICIAL_BUILD)
     switches::kRendererCrashTest,
     switches::kRendererStartupDialog,
-    switches::kNoSandbox,
+    switches::kShowPaintRects,
+    switches::kSilentDumpOnDCHECK,
+    switches::kSimpleDataSource,
     switches::kTestSandbox,
-    switches::kDisableSeccompSandbox,
-    switches::kEnableSeccompSandbox,
-#if !defined (GOOGLE_CHROME_BUILD)
-    // These are unsupported and not fully tested modes, so don't enable them
-    // for official Google Chrome builds.
-    switches::kInProcessPlugins,
-#endif  // GOOGLE_CHROME_BUILD
-    switches::kAllowScriptingGallery,
-    switches::kDomAutomationController,
-    switches::kUserAgent,
-    switches::kNoReferrers,
-    switches::kJavaScriptFlags,
-    switches::kRecordMode,
-    switches::kPlaybackMode,
-    switches::kNoJsRandomness,
-    switches::kDisableBreakpad,
-    switches::kFullMemoryCrashReport,
-    switches::kV,
-    switches::kVModule,
-    switches::kEnableLogging,
-    switches::kDumpHistogramsOnExit,
-    switches::kDisableLogging,
-    switches::kLoggingLevel,
-    switches::kDebugPrint,
-    switches::kMemoryProfiling,
-    switches::kEnableWatchdog,
-    switches::kMessageLoopHistogrammer,
-    switches::kEnableDCHECK,
-    switches::kSilentDumpOnDCHECK,
-    switches::kUseLowFragHeapCrt,
-    switches::kEnableSearchProviderApiV2,
-    switches::kEnableStatsTable,
-    switches::kExperimentalSpellcheckerFeatures,
-    switches::kDisableAudio,
-    switches::kSimpleDataSource,
-    switches::kEnableBenchmarking,
-    switches::kEnableNaCl,
-    switches::kInternalNaCl,
-    switches::kInternalPepper,
-    switches::kRegisterPepperPlugins,
-    switches::kDisableDatabases,
-    switches::kDisableDesktopNotifications,
-    switches::kDisableWebSockets,
-    switches::kDisableLocalStorage,
-    switches::kDisableSessionStorage,
-    switches::kDisableSharedWorkers,
-    switches::kDisableApplicationCache,
-    switches::kDisableDeviceOrientation,
-    switches::kDisableIndexedDatabase,
-    switches::kDisableSpeechInput,
-    switches::kDisableGeolocation,
-    switches::kShowPaintRects,
-    switches::kEnableOpenMax,
-    switches::kVideoThreads,
-    switches::kEnableVideoFullscreen,
-    switches::kEnableVideoLogging,
-    switches::kEnableTouch,
-    // We propagate the Chrome Frame command line here as well in case the
-    // renderer is not run in the sandbox.
-    switches::kChromeFrame,
-    // We need to propagate this flag to determine whether to make the
-    // WebGLArray constructors on the DOMWindow visible. This
-    // information is needed very early during bringup. We prefer to
-    // use the WebPreferences to set this flag on a page-by-page basis.
-    switches::kDisableExperimentalWebGL,
-    switches::kDisableGLSLTranslator,
-    switches::kInProcessWebGL,
     // This flag needs to be propagated to the renderer process for
     // --in-process-webgl.
     switches::kUseGL,
-    switches::kDisableAcceleratedCompositing,
-#if defined(OS_MACOSX)
-    // Allow this to be set when invoking the browser and relayed along.
-    switches::kEnableSandboxLogging,
-#endif
-    switches::kRemoteShellPort,
-    switches::kEnablePepperTesting,
-    switches::kAllowOutdatedPlugins,
-    switches::kNewChromeUISecurityModel,
-    switches::kEnableRemoting,
-    switches::kEnableClickToPlay,
-    switches::kEnableResourceContentSettings,
-    switches::kEnableAcceleratedDecoding,
-    switches::kDisableFileSystem,
-    switches::kPpapiOutOfProcess,
-    switches::kEnablePrintPreview,
-    switches::kEnableCrxlessWebApps,
-    switches::kDisable3DAPIs,
-    switches::kEnableInBrowserThumbnailing,
-    switches::kEnableWebAudio,
+    switches::kUseLowFragHeapCrt,
+    switches::kUserAgent,
+    switches::kV,
+    switches::kVideoThreads,
+    switches::kVModule,
   };
   renderer_cmd->CopySwitchesFrom(browser_cmd, kSwitchNames,
                                  arraysize(kSwitchNames));
 
   // Disable databases in incognito mode.
   if (profile()->IsOffTheRecord() &&
       !browser_cmd.HasSwitch(switches::kDisableDatabases)) {
     renderer_cmd->AppendSwitch(switches::kDisableDatabases);
   }
 
@@ skipping 75 matching lines @@
   // Check if the process is still starting and we don't have a handle for it
   // yet, in which case this will happen later when InitVisitedLinks is called.
   if (!run_renderer_in_process() &&
       (!child_process_.get() || child_process_->IsStarting())) {
     return;
   }
 
   ExtensionService* service = profile()->GetExtensionService();
   if (!service)
     return;
-  ViewMsg_ExtensionsUpdated_Params params;
+
   for (size_t i = 0; i < service->extensions()->size(); ++i) {
-    const Extension* extension = service->extensions()->at(i);
-    ViewMsg_ExtensionRendererInfo info;
-    info.id = extension->id();
-    info.web_extent = extension->web_extent();
-    info.name = extension->name();
-    info.location = extension->location();
-    info.allowed_to_execute_script_everywhere =
-        extension->CanExecuteScriptEverywhere();
-    info.host_permissions = extension->host_permissions();
-
-    // The icon in the page is 96px.  We'd rather not scale up, so use 128.
-    info.icon_url = extension->GetIconURL(Extension::EXTENSION_ICON_LARGE,
-                                          ExtensionIconSet::MATCH_EXACTLY);
-    if (info.icon_url.is_empty())
-      info.icon_url = GURL("chrome://theme/IDR_APP_DEFAULT_ICON");
-    params.extensions.push_back(info);
+    Send(new ViewMsg_ExtensionLoaded(
+        ViewMsg_ExtensionLoaded_Params(service->extensions()->at(i))));
   }
-
-  Send(new ViewMsg_ExtensionsUpdated(params));
 }
 
 bool BrowserRenderProcessHost::FastShutdownIfPossible() {
   if (run_renderer_in_process())
     return false;  // Single process mode can't do fast shutdown.
 
   if (!child_process_.get() || child_process_->IsStarting() || !GetHandle())
     return false;  // Render process hasn't started or is probably crashed.
 
   // Test if there's an unload listener.
@@ skipping 257 matching lines @@
                                        const NotificationDetails& details) {
   switch (type.value) {
     case NotificationType::USER_SCRIPTS_UPDATED: {
       base::SharedMemory* shared_memory =
           Details<base::SharedMemory>(details).ptr();
       if (shared_memory) {
         SendUserScriptsUpdate(shared_memory);
       }
       break;
     }
-    case NotificationType::EXTENSION_LOADED:
+    case NotificationType::EXTENSION_LOADED: {
+      Send(new ViewMsg_ExtensionLoaded(
+          ViewMsg_ExtensionLoaded_Params(
+              Details<const Extension>(details).ptr())));
+      break;
+    }
     case NotificationType::EXTENSION_UNLOADED: {
-      SendExtensionInfo();
+      Send(new ViewMsg_ExtensionUnloaded(
+          Details<UnloadedExtensionInfo>(details).ptr()->extension->id()));
       break;
     }
     case NotificationType::SPELLCHECK_HOST_REINITIALIZED: {
       InitSpellChecker();
       break;
     }
     case NotificationType::SPELLCHECK_WORD_ADDED: {
       AddSpellCheckWord(
           reinterpret_cast<const Source<SpellCheckHost>*>(&source)->
           ptr()->last_added_word());
@@ skipping 150 matching lines @@
     IPC::PlatformFileForTransit file;
 #if defined(OS_POSIX)
     file = base::FileDescriptor(model_file, false);
 #elif defined(OS_WIN)
     ::DuplicateHandle(::GetCurrentProcess(), model_file, GetHandle(), &file, 0,
                       false, DUPLICATE_SAME_ACCESS);
 #endif
     Send(new ViewMsg_SetPhishingModel(file));
   }
 }