Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 6242007: Fixing plugins block test (Closed)

Created:
9 years, 11 months ago by rohitbm
Modified:
9 years, 3 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M functional/plugins.py View 1 3 chunks +7 lines, -3 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
rohitbm
9 years, 11 months ago (2011-01-19 20:43:13 UTC) #1
Nirnimesh
http://codereview.chromium.org/6242007/diff/1/functional/plugins.py File functional/plugins.py (right): http://codereview.chromium.org/6242007/diff/1/functional/plugins.py#newcode191 functional/plugins.py:191: self.SetOmniboxText('http://vimeo.com') why not use navigateToURL?
9 years, 11 months ago (2011-01-19 21:13:38 UTC) #2
rohitbm
I have uploaded the code with changes. Thanks, Rohit On 2011/01/19 21:13:38, Nirnimesh wrote: > ...
9 years, 11 months ago (2011-01-19 21:55:30 UTC) #3
Nirnimesh
9 years, 11 months ago (2011-01-19 21:59:44 UTC) #4
LGTM, with one nit.

http://codereview.chromium.org/6242007/diff/5001/functional/plugins.py
File functional/plugins.py (right):

http://codereview.chromium.org/6242007/diff/5001/functional/plugins.py#newcod...
functional/plugins.py:194: lambda:self.NavigateToURL('http://vimeo.com'))
need a space after lambda:

Powered by Google App Engine
This is Rietveld 408576698