Using unsigned shifts and masks when dealing with 64-bit addresses.

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 7d18107d92d228c8f6de6e6d519d524e0f5de8ce..641837b72282fc4ea4f65cce2b3c52fd9054f839 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -3367,7 +3367,7 @@ template <> struct SmiTagging<4> {
 
   // For 32-bit systems any 2 bytes aligned pointer can be encoded as smi
   // with a plain reinterpret_cast.
-  static const intptr_t kEncodablePointerMask = 0x1;
+  static const uintptr_t kEncodablePointerMask = 0x1;
   static const int kPointerToSmiShift = 0;
 };
 
@@ -3387,7 +3387,7 @@ template <> struct SmiTagging<8> {
   // It might be not enough to cover stack allocated objects on some platforms.
   static const int kPointerAlignment = 3;
 
-  static const intptr_t kEncodablePointerMask =
+  static const uintptr_t kEncodablePointerMask =
       ~(intptr_t(0xffffffff) << kPointerAlignment);

[Vyacheslav Egorov (Chromium), 2011/01/19 10:19:43]

intptr_t => uintptr_t

[antonm, 2011/01/19 11:16:00]

Done.

 
   static const int kPointerToSmiShift =
@@ -3397,7 +3397,7 @@ template <> struct SmiTagging<8> {
 typedef SmiTagging<kApiPointerSize> PlatformSmiTagging;
 const int kSmiShiftSize = PlatformSmiTagging::kSmiShiftSize;
 const int kSmiValueSize = PlatformSmiTagging::kSmiValueSize;
-const intptr_t kEncodablePointerMask =
+const uintptr_t kEncodablePointerMask =
     PlatformSmiTagging::kEncodablePointerMask;
 const int kPointerToSmiShift = PlatformSmiTagging::kPointerToSmiShift;
 
@@ -3457,7 +3457,7 @@ class Internals {
   }
 
   static inline void* GetExternalPointerFromSmi(internal::Object* value) {
-    const intptr_t address = reinterpret_cast<intptr_t>(value);
+    const uintptr_t address = reinterpret_cast<intptr_t>(value);

[Vyacheslav Egorov (Chromium), 2011/01/19 10:19:43]

<intptr_t> => <uintptr_t> 

[antonm, 2011/01/19 11:16:00]

Done.

     return reinterpret_cast<void*>(address >> kPointerToSmiShift);
   }