Add a command line flag to specify the minimum flash version implementing the NPP_ClearSiteData API.

Add a command line flag to specify the minimum flash version implementing the NPP_ClearSiteData API.

BUG=58235
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71441

[Bernhard Bauer, 2011-01-14 13:52:13]

please review.

[jochen (gone - plz use gerrit), 2011-01-14 13:54:50]

lgtm

[jochen (gone - plz use gerrit), 2011-01-14 13:55:28]

http://codereview.chromium.org/6242002/diff/1/chrome/browser/plugin_data_remo...
File chrome/browser/plugin_data_remover.cc (right):

http://codereview.chromium.org/6242002/diff/1/chrome/browser/plugin_data_remo...
chrome/browser/plugin_data_remover.cc:167:
Version::GetVersionFromString(min_version_string));
btw, what happens if the version string is unparsable?

[Bernhard Bauer, 2011-01-14 13:58:54]

On 2011/01/14 13:55:28, jochen wrote:
>
http://codereview.chromium.org/6242002/diff/1/chrome/browser/plugin_data_remo...
> File chrome/browser/plugin_data_remover.cc (right):
> 
>
http://codereview.chromium.org/6242002/diff/1/chrome/browser/plugin_data_remo...
> chrome/browser/plugin_data_remover.cc:167:
> Version::GetVersionFromString(min_version_string));
> btw, what happens if the version string is unparsable?

GetVersionFromString will return NULL and the check below will fail. Should we
fall back to kMinFlashVersion in that case?

[jochen (gone - plz use gerrit), 2011-01-14 13:59:52]

On 2011/01/14 13:58:54, Bernhard Bauer wrote:
> On 2011/01/14 13:55:28, jochen wrote:
> >
>
http://codereview.chromium.org/6242002/diff/1/chrome/browser/plugin_data_remo...
> > File chrome/browser/plugin_data_remover.cc (right):
> > 
> >
>
http://codereview.chromium.org/6242002/diff/1/chrome/browser/plugin_data_remo...
> > chrome/browser/plugin_data_remover.cc:167:
> > Version::GetVersionFromString(min_version_string));
> > btw, what happens if the version string is unparsable?
> 
> GetVersionFromString will return NULL and the check below will fail. Should we
> fall back to kMinFlashVersion in that case?

that sounds like a reasonable thing to do

[Bernhard Bauer, 2011-01-14 14:15:03]

On 2011/01/14 13:59:52, jochen wrote:
> On 2011/01/14 13:58:54, Bernhard Bauer wrote:
> > On 2011/01/14 13:55:28, jochen wrote:
> > >
> >
>
http://codereview.chromium.org/6242002/diff/1/chrome/browser/plugin_data_remo...
> > > File chrome/browser/plugin_data_remover.cc (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/6242002/diff/1/chrome/browser/plugin_data_remo...
> > > chrome/browser/plugin_data_remover.cc:167:
> > > Version::GetVersionFromString(min_version_string));
> > > btw, what happens if the version string is unparsable?
> > 
> > GetVersionFromString will return NULL and the check below will fail. Should
we
> > fall back to kMinFlashVersion in that case?
> 
> that sounds like a reasonable thing to do

done.

[jochen (gone - plz use gerrit), 2011-01-14 14:25:36]

lg, thx