Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 6241016: Fix a layout issue in the input method list in the language options on Chrome (Closed)

Created:
9 years, 11 months ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
kochi
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix a layout issue in the input method list in the language options on Chrome Before the fix, we didn't have any space between a checkbox and the input method name, which looked bad. Note that we don't have this problem in other options pages, as our HTML files are formatted like: <input id="foobar" type="checkbox"> <span i18n-content="foobar"> the line break between two elements make a text node of a single space inbetween. BUG=chromium-os:11248 TEST=on chrome os, open the language options, see the input method list. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72765

Patch Set 1 #

Patch Set 2 : minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/options/language_options.js View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
9 years, 11 months ago (2011-01-25 09:17:23 UTC) #1
kochi
Then why not enclosing the textnode in <span>, rather than adding hacky space?
9 years, 11 months ago (2011-01-25 09:27:55 UTC) #2
satorux1
It doesn't work. We still need a text node of a single space between <input> ...
9 years, 11 months ago (2011-01-25 09:49:08 UTC) #3
kochi
9 years, 11 months ago (2011-01-25 09:58:54 UTC) #4
LGTM

Sorry I didn't understand what the original description said.

Powered by Google App Engine
This is Rietveld 408576698