Make Pepper resize the buffer through the command buffer.

Make Pepper resize the buffer through the command buffer.

This adds support for glResizeCHROMIUM for off-screen contexts.

BUG=none
TEST=Pepper flash.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72575

[apatrick, 2011-01-25 18:22:48]

LGTM. Thanks.

http://codereview.chromium.org/6241015/diff/1/webkit/plugins/ppapi/ppb_surfac...
File webkit/plugins/ppapi/ppb_surface_3d_impl.cc (right):

http://codereview.chromium.org/6241015/diff/1/webkit/plugins/ppapi/ppb_surfac...
webkit/plugins/ppapi/ppb_surface_3d_impl.cc:110:
context->GetGLES2Implementation()->ResizeCHROMIUM(
The issue with calling this concurrently with GL calls on another thread remain.
Not necessarily a problem, maybe just something to be documented.

[neb, 2011-01-25 19:16:06]

http://codereview.chromium.org/6241015/diff/1/chrome/gpu/gpu_command_buffer_s...
File chrome/gpu/gpu_command_buffer_stub.cc (right):

http://codereview.chromium.org/6241015/diff/1/chrome/gpu/gpu_command_buffer_s...
chrome/gpu/gpu_command_buffer_stub.cc:265: NewCallback(this,
This can fit on the same line, no?

http://codereview.chromium.org/6241015/diff/1/webkit/plugins/ppapi/ppb_surfac...
File webkit/plugins/ppapi/ppb_surface_3d_impl.cc (right):

http://codereview.chromium.org/6241015/diff/1/webkit/plugins/ppapi/ppb_surfac...
webkit/plugins/ppapi/ppb_surface_3d_impl.cc:109: const gfx::Size& size =
instance()->position().size();
I'm wondering if we can split this right now into a part that sets up callbacks
and the part that touches the command buffer because we'll use a different
command buffer in nacl proxy.

[Antoine Labour, 2011-01-25 19:32:24]

http://codereview.chromium.org/6241015/diff/1/chrome/gpu/gpu_command_buffer_s...
File chrome/gpu/gpu_command_buffer_stub.cc (right):

http://codereview.chromium.org/6241015/diff/1/chrome/gpu/gpu_command_buffer_s...
chrome/gpu/gpu_command_buffer_stub.cc:265: NewCallback(this,
On 2011/01/25 19:16:06, neb wrote:
> This can fit on the same line, no?

Done.

http://codereview.chromium.org/6241015/diff/1/webkit/plugins/ppapi/ppb_surfac...
File webkit/plugins/ppapi/ppb_surface_3d_impl.cc (right):

http://codereview.chromium.org/6241015/diff/1/webkit/plugins/ppapi/ppb_surfac...
webkit/plugins/ppapi/ppb_surface_3d_impl.cc:109: const gfx::Size& size =
instance()->position().size();
On 2011/01/25 19:16:06, neb wrote:
> I'm wondering if we can split this right now into a part that sets up
callbacks
> and the part that touches the command buffer because we'll use a different
> command buffer in nacl proxy.

Right, I have a follow up CL where the command buffer implementation is created
explicitly in the ppb_context_3d_impl instead of implicitly by the delegate. In
the case of a proxy'ed plugin, it would not do that, and we would skip the
ResizeChromium (here) and the SwapBuffers (below), giving responsibility of that
to the plugin side (same with NaCl).
Since it's in a follow-up CL, I don't want to do too much refactoring just yet,
keeping this one simple.

http://codereview.chromium.org/6241015/diff/1/webkit/plugins/ppapi/ppb_surfac...
webkit/plugins/ppapi/ppb_surface_3d_impl.cc:110:
context->GetGLES2Implementation()->ResizeCHROMIUM(
On 2011/01/25 18:22:48, apatrick wrote:
> The issue with calling this concurrently with GL calls on another thread
remain.
> Not necessarily a problem, maybe just something to be documented.

In truth, none of the pepper calls are thread-safe, aside of CallOnMainThread,
and this is no different.
I could add a note here, but it's the same with SwapBuffers below, and virtually
all the pepper calls. The GL calls themselves aren't thread safe (the context
lookup), so in practice you can't call GL from another thread currently.