Add a new presubmit check to enforce automatic svn properties in svn config.

PRESUBMIT.py

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 50 matching lines @@
         files.append(f)
 
   if len(files):
     return [ output_api.PresubmitError(
         'Found Singleton<T> in the following header files.\n' +
         'Please move them to an appropriate source file so that the ' +
         'template gets instantiated in a single compilation unit.',
         files) ]
   return []
 
+
+def _CheckSubversionConfig(input_api, output_api):
+  """Verifies the subversion config file is correctly setup.
+
+  Checks that autoprops are enabled, returns an error otherwise.
+  """
+  join = input_api.os_path.join
+  if input_api.platform == 'win32':
+    appdata = input_api.environ.get('APPDATA', '')
+    if not appdata:
+      return [output_api.PresubmitError('%APPDATA% is not configured.')]
+    path = join(appdata, 'Subversion', 'config')
+  else:
+    home = input_api.environ.get('HOME', '')
+    if not home:
+      return [output_api.PresubmitError('$HOME is not configured.')]
+    path = join(home, '.subversion', 'config')
+
+  error_msg = (
+      'Please look at http://dev.chromium.org/developers/coding-style to\n'
+      'configure your subversion configuration file. This enables automatic\n'
+      'properties to simplify the project maintenance.')
+
+  try:
+    lines = open(path, 'r').read().splitlines()
+    # Make sure auto-props is enabled and check for 2 Chromium standard
+    # auto-prop.
+    if (not '*.cc = svn:eol-style=LF' in lines or
+        not '*.pdf = svn:mime-type=application/pdf' in lines or
+        not 'enable-auto-props = yes' in lines):
+      return [
+          output_api.PresubmitError(
+              'It looks like you have not configured your subversion config '
+              'file.\n' + error_msg)

[wtc, 2011/01/31 22:37:36]

I got this error message when I tried to commit a CL today.
I was confused because I configured my ~/.subversion/config file
before.

I believe it's because my ~/.subversion/config file didn't
have the '*.pdf = svn:mime-type=application/pdf' line.
I suspect the *.pdf line is a new requirement.  So it may
be better to add ", or your subversion config file is not up-to-date"
to the error message.

+      ]
+  except (OSError, IOError):
+    return [
+        output_api.PresubmitError(
+            'Can\'t find your subversion config file.\n' + error_msg)
+    ]
+  return []
+
+
 def _CheckConstNSObject(input_api, output_api, source_file_filter):
   """Checks to make sure no objective-c files have |const NSSomeClass*|."""
   pattern = input_api.re.compile(r'const\s+NS\w*\s*\*')
   files = []
   for f in input_api.AffectedSourceFiles(source_file_filter):
     if f.LocalPath().endswith('.h') or f.LocalPath().endswith('.mm'):
       contents = input_api.ReadFile(f)
       if pattern.search(contents):
         files.append(f)
 
@@ skipping 84 matching lines @@
   results.extend(input_api.canned_checks.CheckBuildbotPendingBuilds(
       input_api,
       output_api,
       'http://build.chromium.org/p/chromium/json/builders?filter=1',
       6,
       IGNORED_BUILDERS))
   results.extend(input_api.canned_checks.CheckChangeHasBugField(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasTestField(
       input_api, output_api))
+  results.extend(_CheckSubversionConfig(input_api, output_api))
   return results
 
 
 def GetPreferredTrySlaves():
   return ['win', 'linux', 'mac']