Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
6241006:
DOMUI: Polish common HTML controls to match the rest of the DOMUI pages. (Closed)
|
Created:
9 years, 11 months ago by James Hawkins Modified:
9 years, 7 months ago CC:
chromium-reviews, arv (Not doing code reviews), Glen Murphy Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionDOMUI: Style common HTML controls to match the rest of the DOMUI pages.
CSS values provided by Glen Murphy <glen@chromium.org>;.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71836
Patch Set 1 #
Total comments: 26
Patch Set 2 : Review fixes. #
Total comments: 1
Messages
Total messages: 8 (0 generated)
This isn't using webkit-linear-gradient; I could use some help on the transformations for that.
I'm kind of confused why we are styling form controls in this way? Should we apply the same CSS to all DOMUI then? There is also chrome/browser/resources/shared/css/button.css. Should we unify these? http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:558: background: -webkit-gradient(linear, left top, left bottom, color-stop(0, #fafafa), color-stop(0.4, #f4f4f4), color-stop(1, #e5e5e5)); -webkit-linear-gradient(#fafafa, #f4f4f4 40%, #e5e5e5) http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:570: background: #ebebeb -webkit-gradient(linear, left top, left bottom, color-stop(0, #fefefe), color-stop(0.4, #f8f8f8), color-stop(1, #e9e9e9)); -webkit-linear-gradient(#fefefe, #f8f8f8 40%, #e9e9e9) http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:578: background: #ebebeb -webkit-gradient(linear, left top, left bottom, color-stop(0, #f4f4f4), color-stop(0.4, #efefef), color-stop(1, #dcdcdc)); -webkit-linear-gradient(#f4f4f4, #efefef 40%, #dcdcdc) http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:587: background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA4AAAAICAYAAADJEc7MAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyBpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMC1jMDYwIDYxLjEzNDc3NywgMjAxMC8wMi8xMi0xNzozMjowMCAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNSBXaW5kb3dzIiB4bXBNTTpJbnN0YW5jZUlEPSJ4bXAuaWlkOjA5MDMwMzEzMUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1IiB4bXBNTTpEb2N1bWVudElEPSJ4bXAuZGlkOjA5MDMwMzE0MUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1Ij4gPHhtcE1NOkRlcml2ZWRGcm9tIHN0UmVmOmluc3RhbmNlSUQ9InhtcC5paWQ6MDkwMzAzMTExRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiIHN0UmVmOmRvY3VtZW50SUQ9InhtcC5kaWQ6MDkwMzAzMTIxRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiLz4gPC9yZGY6RGVzY3JpcHRpb24+IDwvcmRmOlJERj4gPC94OnhtcG1ldGE+IDw/eHBhY2tldCBlbmQ9InIiPz5pY8xsAAAAbUlEQVR42mL8//8/AzmAEYijgJgHj5ovQMOXYYgmAgEzM/M3IPM/OgaJg+RBrkLHIEJhwYIFC9nY2H4iawLxQeIgeVwaMTQT0oSsEa6Zj4/vCyFN6BrBmt++fdtESBMIM2KJDlYg/k0oOgACDABJirkKokz/DAAAAABJRU5ErkJggg=="), -webkit-gradient(linear, left top, left bottom, color-stop(0, #fafafa), color-stop(0.4, #f4f4f4), color-stop(1, #e5e5e5)); -webkit-linear-gradient(#fafafa, #f4f4f4 40%, #e5e5e5) http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:587: background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA4AAAAICAYAAADJEc7MAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyBpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMC1jMDYwIDYxLjEzNDc3NywgMjAxMC8wMi8xMi0xNzozMjowMCAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNSBXaW5kb3dzIiB4bXBNTTpJbnN0YW5jZUlEPSJ4bXAuaWlkOjA5MDMwMzEzMUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1IiB4bXBNTTpEb2N1bWVudElEPSJ4bXAuZGlkOjA5MDMwMzE0MUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1Ij4gPHhtcE1NOkRlcml2ZWRGcm9tIHN0UmVmOmluc3RhbmNlSUQ9InhtcC5paWQ6MDkwMzAzMTExRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiIHN0UmVmOmRvY3VtZW50SUQ9InhtcC5kaWQ6MDkwMzAzMTIxRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiLz4gPC9yZGY6RGVzY3JpcHRpb24+IDwvcmRmOlJERj4gPC94OnhtcG1ldGE+IDw/eHBhY2tldCBlbmQ9InIiPz5pY8xsAAAAbUlEQVR42mL8//8/AzmAEYijgJgHj5ovQMOXYYgmAgEzM/M3IPM/OgaJg+RBrkLHIEJhwYIFC9nY2H4iawLxQeIgeVwaMTQT0oSsEa6Zj4/vCyFN6BrBmt++fdtESBMIM2KJDlYg/k0oOgACDABJirkKokz/DAAAAABJRU5ErkJggg=="), -webkit-gradient(linear, left top, left bottom, color-stop(0, #fafafa), color-stop(0.4, #f4f4f4), color-stop(1, #e5e5e5)); I would prefer if we could check in these images http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:588: background-position: center right; This needs RTL support http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:599: You need to provide button:focus and button:disabled as well. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:601: -webkit-border-radius: 2px; You do not need to repeat this. The "select" rule is already providing this. Just remove all the duplicates from the :hover rules http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:603: background: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA4AAAAICAYAAADJEc7MAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyBpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMC1jMDYwIDYxLjEzNDc3NywgMjAxMC8wMi8xMi0xNzozMjowMCAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNSBXaW5kb3dzIiB4bXBNTTpJbnN0YW5jZUlEPSJ4bXAuaWlkOjA5MDMwMzEzMUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1IiB4bXBNTTpEb2N1bWVudElEPSJ4bXAuZGlkOjA5MDMwMzE0MUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1Ij4gPHhtcE1NOkRlcml2ZWRGcm9tIHN0UmVmOmluc3RhbmNlSUQ9InhtcC5paWQ6MDkwMzAzMTExRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiIHN0UmVmOmRvY3VtZW50SUQ9InhtcC5kaWQ6MDkwMzAzMTIxRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiLz4gPC9yZGY6RGVzY3JpcHRpb24+IDwvcmRmOlJERj4gPC94OnhtcG1ldGE+IDw/eHBhY2tldCBlbmQ9InIiPz5pY8xsAAAAbUlEQVR42mL8//8/AzmAEYijgJgHj5ovQMOXYYgmAgEzM/M3IPM/OgaJg+RBrkLHIEJhwYIFC9nY2H4iawLxQeIgeVwaMTQT0oSsEa6Zj4/vCyFN6BrBmt++fdtESBMIM2KJDlYg/k0oOgACDABJirkKokz/DAAAAABJRU5ErkJggg=="), -webkit-gradient(linear, left top, left bottom, color-stop(0, #fefefe), color-stop(0.4, #f8f8f8), color-stop(1, #e9e9e9)); -webkit-linear-gradient(#fefefe, #f8f8f8 40%, #e9e9e9) http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:604: background-position: center right; RTL http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:623: position:relative; ws after : http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:624: top:1px; I think the right way to do this is to change the margin-top below but I'm not sure if Glen wanted non labeled checkboxes/radio buttons to moved down as well.
http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:558: background: -webkit-gradient(linear, left top, left bottom, color-stop(0, #fafafa), color-stop(0.4, #f4f4f4), color-stop(1, #e5e5e5)); On 2011/01/18 18:49:25, arv wrote: > -webkit-linear-gradient(#fafafa, #f4f4f4 40%, #e5e5e5) I have a tool for this. http://www.corp.google.com/~arv/no_crawl/webkit-gradient-parse/test.html It does not handle all gradients but it has helped me a lot already.
To add some background - the CSS comes from some drafts of design work we're doing on widgets - it's not finished yet, so expect it it change over time as well. On Tue, Jan 18, 2011 at 10:52 AM, <arv@chromium.org> wrote: > > http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... > File chrome/browser/resources/options/options_page.css (right): > > http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... > chrome/browser/resources/options/options_page.css:558: background: > -webkit-gradient(linear, left top, left bottom, color-stop(0, #fafafa), > color-stop(0.4, #f4f4f4), color-stop(1, #e5e5e5)); > On 2011/01/18 18:49:25, arv wrote: >> >> -webkit-linear-gradient(#fafafa, #f4f4f4 40%, #e5e5e5) > > I have a tool for this. > > http://www.corp.google.com/~arv/no_crawl/webkit-gradient-parse/test.html > > It does not handle all gradients but it has helped me a lot already. > > http://codereview.chromium.org/6241006/ >
I'm uploading a separate CL for the select png. I'd like to hold off on refactoring this for all DOMUI for now. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:558: background: -webkit-gradient(linear, left top, left bottom, color-stop(0, #fafafa), color-stop(0.4, #f4f4f4), color-stop(1, #e5e5e5)); On 2011/01/18 18:52:51, arv wrote: > On 2011/01/18 18:49:25, arv wrote: > > -webkit-linear-gradient(#fafafa, #f4f4f4 40%, #e5e5e5) > > I have a tool for this. > > http://www.corp.google.com/%7Earv/no_crawl/webkit-gradient-parse/test.html > > It does not handle all gradients but it has helped me a lot already. Awesome, that's really helpful. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:558: background: -webkit-gradient(linear, left top, left bottom, color-stop(0, #fafafa), color-stop(0.4, #f4f4f4), color-stop(1, #e5e5e5)); On 2011/01/18 18:49:25, arv wrote: > -webkit-linear-gradient(#fafafa, #f4f4f4 40%, #e5e5e5) Done. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:570: background: #ebebeb -webkit-gradient(linear, left top, left bottom, color-stop(0, #fefefe), color-stop(0.4, #f8f8f8), color-stop(1, #e9e9e9)); On 2011/01/18 18:49:25, arv wrote: > -webkit-linear-gradient(#fefefe, #f8f8f8 40%, #e9e9e9) Done. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:578: background: #ebebeb -webkit-gradient(linear, left top, left bottom, color-stop(0, #f4f4f4), color-stop(0.4, #efefef), color-stop(1, #dcdcdc)); On 2011/01/18 18:49:25, arv wrote: > -webkit-linear-gradient(#f4f4f4, #efefef 40%, #dcdcdc) Done. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:587: background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA4AAAAICAYAAADJEc7MAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyBpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMC1jMDYwIDYxLjEzNDc3NywgMjAxMC8wMi8xMi0xNzozMjowMCAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNSBXaW5kb3dzIiB4bXBNTTpJbnN0YW5jZUlEPSJ4bXAuaWlkOjA5MDMwMzEzMUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1IiB4bXBNTTpEb2N1bWVudElEPSJ4bXAuZGlkOjA5MDMwMzE0MUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1Ij4gPHhtcE1NOkRlcml2ZWRGcm9tIHN0UmVmOmluc3RhbmNlSUQ9InhtcC5paWQ6MDkwMzAzMTExRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiIHN0UmVmOmRvY3VtZW50SUQ9InhtcC5kaWQ6MDkwMzAzMTIxRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiLz4gPC9yZGY6RGVzY3JpcHRpb24+IDwvcmRmOlJERj4gPC94OnhtcG1ldGE+IDw/eHBhY2tldCBlbmQ9InIiPz5pY8xsAAAAbUlEQVR42mL8//8/AzmAEYijgJgHj5ovQMOXYYgmAgEzM/M3IPM/OgaJg+RBrkLHIEJhwYIFC9nY2H4iawLxQeIgeVwaMTQT0oSsEa6Zj4/vCyFN6BrBmt++fdtESBMIM2KJDlYg/k0oOgACDABJirkKokz/DAAAAABJRU5ErkJggg=="), -webkit-gradient(linear, left top, left bottom, color-stop(0, #fafafa), color-stop(0.4, #f4f4f4), color-stop(1, #e5e5e5)); On 2011/01/18 18:49:25, arv wrote: > -webkit-linear-gradient(#fafafa, #f4f4f4 40%, #e5e5e5) Done. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:587: background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA4AAAAICAYAAADJEc7MAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyBpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMC1jMDYwIDYxLjEzNDc3NywgMjAxMC8wMi8xMi0xNzozMjowMCAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNSBXaW5kb3dzIiB4bXBNTTpJbnN0YW5jZUlEPSJ4bXAuaWlkOjA5MDMwMzEzMUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1IiB4bXBNTTpEb2N1bWVudElEPSJ4bXAuZGlkOjA5MDMwMzE0MUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1Ij4gPHhtcE1NOkRlcml2ZWRGcm9tIHN0UmVmOmluc3RhbmNlSUQ9InhtcC5paWQ6MDkwMzAzMTExRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiIHN0UmVmOmRvY3VtZW50SUQ9InhtcC5kaWQ6MDkwMzAzMTIxRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiLz4gPC9yZGY6RGVzY3JpcHRpb24+IDwvcmRmOlJERj4gPC94OnhtcG1ldGE+IDw/eHBhY2tldCBlbmQ9InIiPz5pY8xsAAAAbUlEQVR42mL8//8/AzmAEYijgJgHj5ovQMOXYYgmAgEzM/M3IPM/OgaJg+RBrkLHIEJhwYIFC9nY2H4iawLxQeIgeVwaMTQT0oSsEa6Zj4/vCyFN6BrBmt++fdtESBMIM2KJDlYg/k0oOgACDABJirkKokz/DAAAAABJRU5ErkJggg=="), -webkit-gradient(linear, left top, left bottom, color-stop(0, #fafafa), color-stop(0.4, #f4f4f4), color-stop(1, #e5e5e5)); On 2011/01/18 18:49:25, arv wrote: > I would prefer if we could check in these images Done. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:588: background-position: center right; On 2011/01/18 18:49:25, arv wrote: > This needs RTL support Done. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:599: On 2011/01/18 18:49:25, arv wrote: > You need to provide button:focus and button:disabled as well. Done. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:601: -webkit-border-radius: 2px; On 2011/01/18 18:49:25, arv wrote: > You do not need to repeat this. The "select" rule is already providing this. > > Just remove all the duplicates from the :hover rules Done. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:603: background: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA4AAAAICAYAAADJEc7MAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyBpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMC1jMDYwIDYxLjEzNDc3NywgMjAxMC8wMi8xMi0xNzozMjowMCAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNSBXaW5kb3dzIiB4bXBNTTpJbnN0YW5jZUlEPSJ4bXAuaWlkOjA5MDMwMzEzMUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1IiB4bXBNTTpEb2N1bWVudElEPSJ4bXAuZGlkOjA5MDMwMzE0MUVBRTExRTA5NUM0QzJENTZCN0I5Mjk1Ij4gPHhtcE1NOkRlcml2ZWRGcm9tIHN0UmVmOmluc3RhbmNlSUQ9InhtcC5paWQ6MDkwMzAzMTExRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiIHN0UmVmOmRvY3VtZW50SUQ9InhtcC5kaWQ6MDkwMzAzMTIxRUFFMTFFMDk1QzRDMkQ1NkI3QjkyOTUiLz4gPC9yZGY6RGVzY3JpcHRpb24+IDwvcmRmOlJERj4gPC94OnhtcG1ldGE+IDw/eHBhY2tldCBlbmQ9InIiPz5pY8xsAAAAbUlEQVR42mL8//8/AzmAEYijgJgHj5ovQMOXYYgmAgEzM/M3IPM/OgaJg+RBrkLHIEJhwYIFC9nY2H4iawLxQeIgeVwaMTQT0oSsEa6Zj4/vCyFN6BrBmt++fdtESBMIM2KJDlYg/k0oOgACDABJirkKokz/DAAAAABJRU5ErkJggg=="), -webkit-gradient(linear, left top, left bottom, color-stop(0, #fefefe), color-stop(0.4, #f8f8f8), color-stop(1, #e9e9e9)); On 2011/01/18 18:49:25, arv wrote: > -webkit-linear-gradient(#fefefe, #f8f8f8 40%, #e9e9e9) Done. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:604: background-position: center right; On 2011/01/18 18:49:25, arv wrote: > RTL Done. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:623: position:relative; On 2011/01/18 18:49:25, arv wrote: > ws after : Done. http://codereview.chromium.org/6241006/diff/1/chrome/browser/resources/option... chrome/browser/resources/options/options_page.css:624: top:1px; On 2011/01/18 18:49:25, arv wrote: > I think the right way to do this is to change the margin-top below but I'm not > sure if Glen wanted non labeled checkboxes/radio buttons to moved down as well. For now I'd like to leave this as is, then revisit the TODO w/ appropriate changes for all platforms. I tried mucking with margin-top, but it didn't work.
+stuartmorgan
LGTM http://codereview.chromium.org/6241006/diff/7001/chrome/browser/resources/opt... File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/6241006/diff/7001/chrome/browser/resources/opt... chrome/browser/resources/options/options_page.css:532: input[type='text'] { We probably need more types here eventually.
Belated LGTM |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
