Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: net/base/net_util_unittest.cc

Issue 6241001: wstring: make net::GetSuggestedFilename return utf-16 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_util.cc ('k') | ui/base/dragdrop/os_exchange_data_provider_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_util_unittest.cc
diff --git a/net/base/net_util_unittest.cc b/net/base/net_util_unittest.cc
index 77d3a0077019311cabd91230d9cf6eaa93fb81d6..bf51f1c2a271b10abaeaded45294b56616035a79 100644
--- a/net/base/net_util_unittest.cc
+++ b/net/base/net_util_unittest.cc
@@ -1214,21 +1214,12 @@ TEST(NetUtilTest, GetSuggestedFilename) {
#endif
};
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
-#if defined(OS_WIN)
- FilePath default_name(test_cases[i].default_filename);
-#else
- FilePath default_name(
- base::SysWideToNativeMB(test_cases[i].default_filename));
-#endif
- FilePath filename = net::GetSuggestedFilename(
+ std::wstring default_name = test_cases[i].default_filename;
+ string16 filename = net::GetSuggestedFilename(
GURL(test_cases[i].url), test_cases[i].content_disp_header,
- test_cases[i].referrer_charset, default_name);
-#if defined(OS_WIN)
- EXPECT_EQ(std::wstring(test_cases[i].expected_filename), filename.value())
-#else
- EXPECT_EQ(base::SysWideToNativeMB(test_cases[i].expected_filename),
- filename.value())
-#endif
+ test_cases[i].referrer_charset, WideToUTF16(default_name));
+ EXPECT_EQ(std::wstring(test_cases[i].expected_filename),
+ UTF16ToWide(filename))
<< "Iteration " << i << ": " << test_cases[i].url;
}
}
« no previous file with comments | « net/base/net_util.cc ('k') | ui/base/dragdrop/os_exchange_data_provider_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698