chrome/browser/prefs/pref_service.h - Issue 6240013: Make proxy settings one atomic dictionary in the PrefStores such that modifications are atomic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_service.h

Issue 6240013: Make proxy settings one atomic dictionary in the PrefStores such that modifications are atomic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/out/Debug

Patch Set: Updated to ToT and addressed Matt's comments in base-CL Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/policy/configuration_policy_pref_store_unittest.cc ('K') | « chrome/browser/prefs/command_line_pref_store_unittest.cc ('k') | chrome/browser/prefs/pref_service.cc » ('j') | chrome/browser/prefs/proxy_prefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/pref_service.h

diff --git a/chrome/browser/prefs/pref_service.h b/chrome/browser/prefs/pref_service.h

index 5891a1dc527174cb8a7c2bf28446d8801c6adb24..18756f718e077fe6df8f1a4d374cca28daab8fbc 100644

--- a/chrome/browser/prefs/pref_service.h

+++ b/chrome/browser/prefs/pref_service.h

@@ -147,6 +147,9 @@ class PrefService : public base::NonThreadSafe {

void RegisterFilePathPref(const char* path, const FilePath& default_value);

void RegisterListPref(const char* path);

void RegisterDictionaryPref(const char* path);

+ // These take ownership of the default_value:

+ void RegisterListPref(const char* path, ListValue* default_value);

+ void RegisterDictionaryPref(const char* path, DictionaryValue* default_value);

// These variants use a default value from the locale dll instead.

void RegisterLocalizedBooleanPref(const char* path,