Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/prefs/pref_set_observer.cc

Issue 6240013: Make proxy settings one atomic dictionary in the PrefStores such that modifications are atomic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/out/Debug
Patch Set: Updated to ToT and addressed Matt's comments in base-CL Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prefs/pref_set_observer.h" 5 #include "chrome/browser/prefs/pref_set_observer.h"
6 6
7 #include "chrome/common/notification_type.h" 7 #include "chrome/common/notification_type.h"
8 #include "chrome/common/pref_names.h" 8 #include "chrome/common/pref_names.h"
9 9
10 PrefSetObserver::PrefSetObserver(PrefService* pref_service, 10 PrefSetObserver::PrefSetObserver(PrefService* pref_service,
(...skipping 29 matching lines...) Expand all
40 return true; 40 return true;
41 } 41 }
42 return false; 42 return false;
43 } 43 }
44 44
45 // static 45 // static
46 PrefSetObserver* PrefSetObserver::CreateProxyPrefSetObserver( 46 PrefSetObserver* PrefSetObserver::CreateProxyPrefSetObserver(
47 PrefService* pref_service, 47 PrefService* pref_service,
48 NotificationObserver* observer) { 48 NotificationObserver* observer) {
49 PrefSetObserver* pref_set = new PrefSetObserver(pref_service, observer); 49 PrefSetObserver* pref_set = new PrefSetObserver(pref_service, observer);
50 pref_set->AddPref(prefs::kProxyMode); 50 pref_set->AddPref(prefs::kProxy);
51 pref_set->AddPref(prefs::kProxyServer);
52 pref_set->AddPref(prefs::kProxyPacUrl);
53 pref_set->AddPref(prefs::kProxyBypassList);
54 51
55 return pref_set; 52 return pref_set;
56 } 53 }
57 54
58 // static 55 // static
59 PrefSetObserver* PrefSetObserver::CreateDefaultSearchPrefSetObserver( 56 PrefSetObserver* PrefSetObserver::CreateDefaultSearchPrefSetObserver(
60 PrefService* pref_service, 57 PrefService* pref_service,
61 NotificationObserver* observer) { 58 NotificationObserver* observer) {
62 PrefSetObserver* pref_set = new PrefSetObserver(pref_service, observer); 59 PrefSetObserver* pref_set = new PrefSetObserver(pref_service, observer);
63 pref_set->AddPref(prefs::kDefaultSearchProviderEnabled); 60 pref_set->AddPref(prefs::kDefaultSearchProviderEnabled);
64 pref_set->AddPref(prefs::kDefaultSearchProviderName); 61 pref_set->AddPref(prefs::kDefaultSearchProviderName);
65 pref_set->AddPref(prefs::kDefaultSearchProviderKeyword); 62 pref_set->AddPref(prefs::kDefaultSearchProviderKeyword);
66 pref_set->AddPref(prefs::kDefaultSearchProviderSearchURL); 63 pref_set->AddPref(prefs::kDefaultSearchProviderSearchURL);
67 pref_set->AddPref(prefs::kDefaultSearchProviderSuggestURL); 64 pref_set->AddPref(prefs::kDefaultSearchProviderSuggestURL);
68 pref_set->AddPref(prefs::kDefaultSearchProviderIconURL); 65 pref_set->AddPref(prefs::kDefaultSearchProviderIconURL);
69 pref_set->AddPref(prefs::kDefaultSearchProviderInstantURL); 66 pref_set->AddPref(prefs::kDefaultSearchProviderInstantURL);
70 pref_set->AddPref(prefs::kDefaultSearchProviderEncodings); 67 pref_set->AddPref(prefs::kDefaultSearchProviderEncodings);
71 68
72 return pref_set; 69 return pref_set;
73 } 70 }
74 71
75 void PrefSetObserver::Observe(NotificationType type, 72 void PrefSetObserver::Observe(NotificationType type,
76 const NotificationSource& source, 73 const NotificationSource& source,
77 const NotificationDetails& details) { 74 const NotificationDetails& details) {
78 if (observer_) 75 if (observer_)
79 observer_->Observe(type, source, details); 76 observer_->Observe(type, source, details);
80 } 77 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698