chrome/browser/task_manager/task_manager.cc - Issue 6240006: Fix DCHECK caused by Task Manager assuming all requests have a render view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 6240006: Fix DCHECK caused by Task Manager assuming all requests have a render view. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/task_manager/task_manager.cc

diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc

index 28418b8a44c2773202e5da2b3c2606148c8e9797..70288303a7c4b2dded1354f753d970cbd7fb8305 100644

--- a/chrome/browser/task_manager/task_manager.cc

+++ b/chrome/browser/task_manager/task_manager.cc

@@ -891,7 +891,7 @@ void TaskManagerModel::OnBytesRead(net::URLRequestJob* job, const char* buf,

if (!ResourceDispatcherHost::RenderViewForRequest(job->request(),

&render_process_host_child_id,

&routing_id)) {

Nico 2011/01/19 16:39:36 Add a comment describing when this happens.

- NOTREACHED();

+ return;

}

// This happens in the IO thread, post it to the UI thread.

« no previous file with comments | « no previous file | no next file » | no next file with comments »