Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 6240006: Fix DCHECK caused by Task Manager assuming all requests have a render view. (Closed)

Created:
9 years, 11 months ago by Wez
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix DCHECK caused by Task Manager assuming all requests have a render view. BUG=69883 TEST=Display Task Manager while one or more tabs are open, and start typing into the Omnibox of one of them. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71807

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix DCHECK caused by Task Manager assuming all requests have a render view. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/task_manager/task_manager.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Wez
This is a one-liner addressing a recent DCHECK issue introduced during cleanup for Coverity.
9 years, 11 months ago (2011-01-18 22:33:00 UTC) #1
Nico
LG with comment addressed. http://codereview.chromium.org/6240006/diff/1/chrome/browser/task_manager/task_manager.cc File chrome/browser/task_manager/task_manager.cc (right): http://codereview.chromium.org/6240006/diff/1/chrome/browser/task_manager/task_manager.cc#newcode893 chrome/browser/task_manager/task_manager.cc:893: &routing_id)) { Add a comment ...
9 years, 11 months ago (2011-01-19 16:39:36 UTC) #2
brettw
LGTM2
9 years, 11 months ago (2011-01-19 21:59:39 UTC) #3
brettw
9 years, 11 months ago (2011-01-19 21:59:40 UTC) #4
LGTM2

Powered by Google App Engine
This is Rietveld 408576698