Issue 6236: Allow gcc to use strict-aliasing rules to control pointer aliasing when...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6236: Allow gcc to use strict-aliasing rules to control pointer aliasing when... (Closed)

Created:
12 years, 2 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Allow gcc to use strict-aliasing rules to control pointer aliasing when optimizing. Obfuscate a few casts with bit_cast to avoid warnings from gcc. Committed: http://code.google.com/p/v8/source/detail?r=428

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -12 lines)			Patch
M	SConstruct	View	2 chunks	+2 lines, -3 lines	1 comment	Download
M	src/api.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/debug.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/debug.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/globals.h	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

12 years, 2 months ago (2008-10-03 12:53:25 UTC) #2

LGTM. We should consider if the bit_cast stuff really belongs in globals.h.

http://codereview.chromium.org/6236/diff/1/8
File SConstruct (right):

http://codereview.chromium.org/6236/diff/1/8#newcode55
Line 55: 'CCFLAGS':      ['-O3']
I trust there are no other references to O9 in this file?

Expand Messages | Collapse Messages