Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: src/runtime.cc

Issue 6234: Refactored the logic for entering the debugger into one abstraction EnterDebu... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/mirror-delay.js ('k') | src/top.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.cc
===================================================================
--- src/runtime.cc (revision 384)
+++ src/runtime.cc (working copy)
@@ -3088,8 +3088,8 @@
static Object* Runtime_DebugBreak(Arguments args) {
- // Just continue if breaks are disabled or if we fail to load the debugger.
- if (Debug::disable_break() || !Debug::Load()) {
+ // Just continue if breaks are disabled.
+ if (Debug::disable_break()) {
return args[0];
}
@@ -3110,8 +3110,11 @@
StackGuard::Continue(DEBUGBREAK);
HandleScope scope;
- SaveBreakFrame save;
- EnterDebuggerContext enter;
+ // Enter the debugger. Just continue if we fail to enter the debugger.
+ EnterDebugger debugger;
+ if (debugger.FailedToEnter()) {
+ return args[0];
+ }
// Notify the debug event listeners.
Debugger::OnDebugBreak(Factory::undefined_value());
« no previous file with comments | « src/mirror-delay.js ('k') | src/top.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698