Issue 6233001: Fix typo, should be ppGoogleNaClPluginChrome.dll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6233001: Fix typo, should be ppGoogleNaClPluginChrome.dll (Closed)

Created:
9 years, 11 months ago by eblake

Modified:
9 years, 7 months ago

Reviewers:
abarth

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/tools/build/win/

Visibility:
Public.

Description

Fix typo, should be ppGoogleNaClPluginChrome.dll Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71075

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	FILES	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth

9 years, 11 months ago (2011-01-11 19:34:30 UTC) #2

LGTM.  Thanks.  I probably made the same mistake on Linux.

Adam


On Tue, Jan 11, 2011 at 11:23 AM,  <eblake@google.com> wrote:
> Reviewers: abarth_google.com,
>
> Description:
> Fix typo, should be ppGoogleNaClPluginChrome.dll
>
>
> Please review this at http://codereview.chromium.org/6233001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/chrome/tools/build/win/
>
> Affected files:
>  M     FILES
>
>
> Index: FILES
> ===================================================================
> --- FILES       (revision 71064)
> +++ FILES       (working copy)
> @@ -8,7 +8,7 @@
>  crash_service.exe
>  First Run
>  gears.dll
> -ppGoogleNaClChrome.dll
> +ppGoogleNaClPluginChrome.dll
>  icudt42.dll
>  locales/ar.dll
>  locales/bg.dll
>
>
>

Expand Messages | Collapse Messages