Issue 6231006: Fix and re-enable slide-in/slide-out of infobars....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6231006: Fix and re-enable slide-in/slide-out of infobars.... (Closed)

Created:
9 years, 11 months ago by erikwright (departed)

Modified:
9 years, 7 months ago

Reviewers:
amit, tommi (sloooow) - chröme

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix and re-enable slide-in/slide-out of infobars. BUG=None TEST=chrome_frame_unittests --gtest_filter=InfobarsInfobarWindowTest.SlidingTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71440

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	chrome_frame/infobars/internal/infobar_window.cc	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
	M	chrome_frame/test/infobar_unittests.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

amit

drive by lgtm http://codereview.chromium.org/6231006/diff/1/chrome_frame/infobars/internal/infobar_window.cc File chrome_frame/infobars/internal/infobar_window.cc (right): http://codereview.chromium.org/6231006/diff/1/chrome_frame/infobars/internal/infobar_window.cc#newcode25 chrome_frame/infobars/internal/infobar_window.cc:25: void __stdcall OnSliderTimer(InfobarWindow::Host* host, nit: this ...

9 years, 11 months ago (2011-01-12 21:32:34 UTC) #2

tommi (sloooow) - chröme

ah! so that was the problem all along :) Glad you found it. LGTM.

9 years, 11 months ago (2011-01-12 21:42:07 UTC) #3

erikwright (departed)

9 years, 11 months ago (2011-01-14 14:43:49 UTC) #4

Thanks! Committed.

http://codereview.chromium.org/6231006/diff/1/chrome_frame/infobars/internal/...
File chrome_frame/infobars/internal/infobar_window.cc (right):

http://codereview.chromium.org/6231006/diff/1/chrome_frame/infobars/internal/...
chrome_frame/infobars/internal/infobar_window.cc:25: void __stdcall
OnSliderTimer(InfobarWindow::Host* host,
On 2011/01/12 21:32:34, amit wrote:
> nit: this should be 'VOID CALLBACK' to follow the TimerProc prototype.

Done.

Expand Messages | Collapse Messages