Issue 6228004: Fix Pepper File IO callbacks.

Issue 6228004: Fix Pepper File IO callbacks. (Closed)

Created:
9 years, 11 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix Pepper File IO callbacks. Add some tests (for aborting calls). Also fix Flash NetConnector callback running. BUG=none TEST=ppapi_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71092

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+332 lines, -67 lines)			Patch
M	ppapi/tests/test_file_io.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	ppapi/tests/test_file_io.cc	View	3 chunks	+204 lines, -1 line	1 comment	Download
M	webkit/plugins/ppapi/ppb_file_io_impl.h	View	4 chunks	+22 lines, -3 lines	1 comment	Download
M	webkit/plugins/ppapi/ppb_file_io_impl.cc	View	23 chunks	+97 lines, -58 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_impl.cc	View	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

LGTM http://codereview.chromium.org/6228004/diff/2001/ppapi/tests/test_file_io.cc File ppapi/tests/test_file_io.cc (right): http://codereview.chromium.org/6228004/diff/2001/ppapi/tests/test_file_io.cc#newcode299 ppapi/tests/test_file_io.cc:299: std::string TestFileIO::TestAbortCalls() { nice! http://codereview.chromium.org/6228004/diff/2001/webkit/plugins/ppapi/ppb_file_io_impl.h File webkit/plugins/ppapi/ppb_file_io_impl.h (right): ...

9 years, 11 months ago (2011-01-11 21:15:41 UTC) #2

viettrungluu

Thanks. On 2011/01/11 21:15:41, brettw wrote: > LGTM > > http://codereview.chromium.org/6228004/diff/2001/ppapi/tests/test_file_io.cc > File ppapi/tests/test_file_io.cc (right): ...

9 years, 11 months ago (2011-01-11 21:21:06 UTC) #3

brettw

9 years, 11 months ago (2011-01-11 22:57:54 UTC) #4

On Tue, Jan 11, 2011 at 1:21 PM,  <viettrungluu@chromium.org> wrote:
> Thanks.
>
> On 2011/01/11 21:15:41, brettw wrote:
>>
>> LGTM
>
>>
>> http://codereview.chromium.org/6228004/diff/2001/ppapi/tests/test_file_io.cc
>> File ppapi/tests/test_file_io.cc (right):
>
>
>
http://codereview.chromium.org/6228004/diff/2001/ppapi/tests/test_file_io.cc#...
>>
>> ppapi/tests/test_file_io.cc:299: std::string TestFileIO::TestAbortCalls()
>> {
>> nice!
>
>
>
http://codereview.chromium.org/6228004/diff/2001/webkit/plugins/ppapi/ppb_fil...
>>
>> File webkit/plugins/ppapi/ppb_file_io_impl.h (right):
>
>
>
http://codereview.chromium.org/6228004/diff/2001/webkit/plugins/ppapi/ppb_fil...
>>
>> webkit/plugins/ppapi/ppb_file_io_impl.h:84: int32_t
>> CommonCallValidation(bool
>> is_opened, PP_CompletionCallback callback);
>> A more clear name for the first arg might be "should_be_opened"
>
> I resisted "should_be_opened" since it might mean that the file should be
> opened
> by CommonCallValidation(). Maybe "should_be_open"?
> "should_already_be_open(ed)"?

should_be_open SGTM

Expand Messages | Collapse Messages