Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: chrome/browser/tab_contents/background_contents.cc

Issue 6226002: Blow away BackgroundContents when RenderView goes away. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome
Patch Set: Removed queueing code in unit test Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/background_contents.cc
diff --git a/chrome/browser/tab_contents/background_contents.cc b/chrome/browser/tab_contents/background_contents.cc
index 1904d3819b24352387248838c0652ed967fedb1b..b4eed25d610e1764d0737a42bf149614663a0d54 100644
--- a/chrome/browser/tab_contents/background_contents.cc
+++ b/chrome/browser/tab_contents/background_contents.cc
@@ -175,6 +175,16 @@ void BackgroundContents::Close(RenderViewHost* render_view_host) {
delete this;
}
+void BackgroundContents::RenderViewGone(RenderViewHost* rvh,
+ base::TerminationStatus status,
+ int error_code) {
+ // Our RenderView went away, so we should go away also, so killing the process
+ // via the TaskManager doesn't permanently leave a BackgroundContents hanging
+ // around the system, blocking future instances from being created
+ // (http://crbug.com/65189).
+ delete this;
+}
+
RendererPreferences BackgroundContents::GetRendererPrefs(
Profile* profile) const {
RendererPreferences preferences;
« no previous file with comments | « chrome/browser/tab_contents/background_contents.h ('k') | chrome/browser/task_manager/task_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698