AU: Don't allow stateful /etc/lsb-release override in normal boot mode...

AU: Don't allow stateful /etc/lsb-release override in normal boot mode...

... on official images except for the release track.

BUG=chromium-os:6244
TEST=unit tests, tested on device

Change-Id: I2d2a634c7b5ac7dd4619f52d1f79b6d88c359e46

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=10d02dd

[adlr, 2011-01-10 22:16:17]

http://codereview.chromium.org/6225001/diff/1/omaha_request_params.cc
File omaha_request_params.cc (right):

http://codereview.chromium.org/6225001/diff/1/omaha_request_params.cc#newcode196
omaha_request_params.cc:196: if (!IsOfficialBuild()) {
perhaps:
if (!IsOfficialBuild() || Dev_Mode_is_Active()) {
?

[petkov, 2011-01-10 22:51:14]

PTAL. Simplified to checking a single ShouldLockDown method and removed rootfs
track validation -- we should really trust what we get from rootfs and there
isn't much point in ping Omaha with an empty track anyway.

http://codereview.chromium.org/6225001/diff/1/omaha_request_params.cc
File omaha_request_params.cc (right):

http://codereview.chromium.org/6225001/diff/1/omaha_request_params.cc#newcode196
omaha_request_params.cc:196: if (!IsOfficialBuild()) {
On 2011/01/10 22:16:17, adlr wrote:
> perhaps:
> if (!IsOfficialBuild() || Dev_Mode_is_Active()) {
> ?

Sure.

[adlr, 2011-01-10 22:55:24]

LGTM. thanks!