Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: src/mirror-delay.js

Issue 6223: Make sure that the name accessor on functions return the expected... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/messages.js ('k') | src/regexp-delay.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mirror-delay.js
===================================================================
--- src/mirror-delay.js (revision 413)
+++ src/mirror-delay.js (working copy)
@@ -338,7 +338,7 @@
function ValueMirror(type, value) {
Mirror.call(this, type);
this.value_ = value;
-};
+}
inherits(ValueMirror, Mirror);
@@ -372,7 +372,7 @@
*/
function UndefinedMirror() {
ValueMirror.call(this, UNDEFINED_TYPE, void 0);
-};
+}
inherits(UndefinedMirror, ValueMirror);
@@ -388,7 +388,7 @@
*/
function NullMirror() {
ValueMirror.call(this, NULL_TYPE, null);
-};
+}
inherits(NullMirror, ValueMirror);
@@ -405,7 +405,7 @@
*/
function BooleanMirror(value) {
ValueMirror.call(this, BOOLEAN_TYPE, value);
-};
+}
inherits(BooleanMirror, ValueMirror);
@@ -428,7 +428,7 @@
*/
function NumberMirror(value) {
ValueMirror.call(this, NUMBER_TYPE, value);
-};
+}
inherits(NumberMirror, ValueMirror);
@@ -451,7 +451,7 @@
*/
function StringMirror(value) {
ValueMirror.call(this, STRING_TYPE, value);
-};
+}
inherits(StringMirror, ValueMirror);
@@ -493,7 +493,7 @@
*/
function ObjectMirror(value, type) {
ValueMirror.call(this, type || OBJECT_TYPE, value);
-};
+}
inherits(ObjectMirror, ValueMirror);
@@ -558,14 +558,14 @@
var names = new Array(limit);
var index = 0;
-
+
// Copy names for named properties.
if (kind & PropertyKind.Named) {
for (var i = 0; index < limit && i < propertyNames.length; i++) {
names[index++] = propertyNames[i];
}
}
-
+
// Copy names for indexed properties.
if (kind & PropertyKind.Indexed) {
for (var i = 0; index < limit && i < elementNames.length; i++) {
@@ -614,7 +614,7 @@
if (this.hasNamedInterceptor() && kind & PropertyKind.Named) {
namedInterceptorNames = %DebugNamedInterceptorPropertyNames(this.value_);
}
-
+
// Get names for indexed interceptor properties.
if (this.hasIndexedInterceptor() && kind & PropertyKind.Indexed) {
indexedInterceptorNames = %DebugIndexedInterceptorElementNames(this.value_);
@@ -646,7 +646,7 @@
var kind = opt_kind || PropertyKind.Named | PropertyKind.Indexed;
var namedInterceptorProperties;
var indexedInterceptorProperties;
-
+
// Get values for named interceptor properties.
if (kind & PropertyKind.Named) {
var names = opt_names || this.interceptorPropertyNames(PropertyKind.Named);
@@ -656,7 +656,7 @@
namedInterceptorProperties[i] = new InterceptorPropertyMirror(this, names[i], value);
}
}
-
+
// Get values for indexed interceptor properties.
if (kind & PropertyKind.Indexed) {
var names = opt_names || this.interceptorPropertyNames(PropertyKind.Indexed);
@@ -805,7 +805,7 @@
function FunctionMirror(value) {
ObjectMirror.call(this, value, FUNCTION_TYPE);
this.resolved_ = true;
-};
+}
inherits(FunctionMirror, ObjectMirror);
@@ -871,12 +871,12 @@
if (this.resolved()) {
// Find all objects constructed from this function.
var result = %DebugConstructedBy(this.value_, opt_max_instances || 0);
-
+
// Make mirrors for all the instances found.
for (var i = 0; i < result.length; i++) {
result[i] = MakeMirror(result[i]);
}
-
+
return result;
} else {
return [];
@@ -918,7 +918,7 @@
this.propertyCount_ = 0;
this.elementCount_ = 0;
this.resolved_ = false;
-};
+}
inherits(UnresolvedFunctionMirror, FunctionMirror);
@@ -960,7 +960,7 @@
*/
function ArrayMirror(value) {
ObjectMirror.call(this, value);
-};
+}
inherits(ArrayMirror, ObjectMirror);
@@ -1008,7 +1008,7 @@
*/
function DateMirror(value) {
ObjectMirror.call(this, value);
-};
+}
inherits(DateMirror, ObjectMirror);
@@ -1033,7 +1033,7 @@
*/
function RegExpMirror(value) {
ObjectMirror.call(this, value, REGEXP_TYPE);
-};
+}
inherits(RegExpMirror, ObjectMirror);
@@ -1098,7 +1098,7 @@
*/
function ErrorMirror(value) {
ObjectMirror.call(this, value, ERROR_TYPE);
-};
+}
inherits(ErrorMirror, ObjectMirror);
@@ -1145,7 +1145,7 @@
this.name_ = name;
this.value_ = value;
this.details_ = details;
-};
+}
inherits(PropertyMirror, Mirror);
@@ -1228,7 +1228,7 @@
*/
function InterceptorPropertyMirror(mirror, name, value) {
PropertyMirror.call(this, mirror, name, value, PropertyType.Interceptor);
-};
+}
inherits(InterceptorPropertyMirror, PropertyMirror);
@@ -1243,7 +1243,7 @@
Mirror.call(this, ACCESSOR_TYPE);
this.getter_ = getter;
this.setter_ = setter;
-};
+}
inherits(AccessorMirror, Mirror);
@@ -1334,7 +1334,7 @@
function FrameDetails(break_id, index) {
this.break_id_ = break_id;
this.details_ = %GetFrameDetails(break_id, index);
-};
+}
FrameDetails.prototype.frameId = function() {
@@ -1440,7 +1440,7 @@
this.break_id_ = break_id;
this.index_ = index;
this.details_ = new FrameDetails(break_id, index);
-};
+}
inherits(FrameMirror, Mirror);
@@ -1641,7 +1641,7 @@
// under which it was looked up.
if (func.name() && func.name() != property.name()) {
result += '(aka ' + func.name() + ')';
- }
+ }
} else {
// The function invoked was not found on the receiver. Use the function
// name if available for the backtrace.
@@ -1665,7 +1665,7 @@
}
result += ')';
}
-
+
return result;
}
@@ -1744,7 +1744,7 @@
function ScriptMirror(script) {
Mirror.call(this, SCRIPT_TYPE);
this.script_ = script;
-};
+}
inherits(ScriptMirror, Mirror);
@@ -1793,8 +1793,8 @@
content.push(MakeJSONPair_('lineCount', NumberToJSON_(this.lineCount())));
content.push(MakeJSONPair_('scriptType', NumberToJSON_(this.scriptType())));
}
-
-
+
+
ScriptMirror.prototype.toText = function() {
var result = '';
result += this.name();
@@ -1813,27 +1813,27 @@
function MakeJSONPair_(name, value) {
return '"' + name + '":' + value;
-};
+}
function ArrayToJSONObject_(content) {
return '{' + content.join(',') + '}';
-};
+}
function ArrayToJSONArray_(content) {
return '[' + content.join(',') + ']';
-};
+}
function BooleanToJSON_(value) {
return String(value);
-};
+}
function NumberToJSON_(value) {
return String(value);
-};
+}
// Mapping of some control characters to avoid the \uXXXX syntax for most
@@ -1886,7 +1886,7 @@
// Simple string with no special characters.
return '"' + value + '"';
-};
+}
/**
@@ -1910,7 +1910,7 @@
f(builtins.GetUTCMinutesFrom(value)) + ':' +
f(builtins.GetUTCSecondsFrom(value)) + '.' +
g(builtins.GetUTCMillisecondsFrom(value)) + 'Z';
-};
+}
/**
* Convert a Date to ISO 8601 format. To avoid depending on the Date object
@@ -1921,4 +1921,4 @@
*/
function DateToJSON_(value) {
return '"' + DateToISO8601_(value) + '"';
-};
+}
« no previous file with comments | « src/messages.js ('k') | src/regexp-delay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698