Make sure that the name accessor on functions return the expected...

src/string.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 28 matching lines @@
     %_SetValueOf(this, value);
   } else {
     return value;
   }
 });
 
 %FunctionSetPrototype($String, new $String());
 
 %AddProperty($String.prototype, "constructor", $String, DONT_ENUM);
 
-%AddProperty($String.prototype, "valueOf", function() {
+%AddProperty($String.prototype, "valueOf", function valueOf() {
   if (!IS_STRING(this) && %ClassOf(this) !== 'String')
     throw new $TypeError('String.prototype.valueOf is not generic');
   return %_ValueOf(this);
 }, DONT_ENUM);
 
-
-%AddProperty($String.prototype, "toString", $String.prototype.valueOf, DONT_ENUM);
+%AddProperty($String.prototype, "toString", function toString() {
+  if (!IS_STRING(this) && %ClassOf(this) !== 'String')
+    throw new $TypeError('String.prototype.toString is not generic');
+  return %_ValueOf(this);
+}, DONT_ENUM);
 
 // ECMA-262 section 15.5.4.5
-%AddProperty($String.prototype, "charCodeAt", function(pos) {
+%AddProperty($String.prototype, "charCodeAt", function charCodeAt(pos) {
   var fast_answer = %_FastCharCodeAt(this, pos);
   if (%_IsSmi(fast_answer)) {
     return fast_answer;
   }
   var subject = ToString(this);
   var index = TO_INTEGER(pos);
   return %StringCharCodeAt(subject, index);
 }, DONT_ENUM);
 
 
 // ECMA-262, section 15.5.4.6
-%AddProperty($String.prototype, "concat", function() {
+%AddProperty($String.prototype, "concat", function concat() {
   var len = %_ArgumentsLength();
   var parts = new $Array(len + 1);
   parts[0] = ToString(this);
   for (var i = 0; i < len; i++)
     parts[i + 1] = ToString(%_Arguments(i));
   return parts.join('');
 }, DONT_ENUM);
 
 // Match ES3 and Safari
 %FunctionSetLength($String.prototype.concat, 1);
 
 
 // SubString is an internal function that returns the sub string of 'string'.
 // If resulting string is of length 1, we use the one character cache
 // otherwise we call the runtime system.
 function SubString(string, start, end) {
   // Use the one character string cache.
   if (start + 1 == end) return %CharFromCode(%StringCharCodeAt(string, start));
   return %StringSlice(string, start, end);
 }
 
 
 // ECMA-262, section 15.5.4.11
-%AddProperty($String.prototype, "replace", function (search, replace) {
+%AddProperty($String.prototype, "replace", function replace(search, replace) {
   var subject = ToString(this);
 
   // Delegate to one of the regular expression variants if necessary.
   if (IS_REGEXP(search)) {
     if (IS_FUNCTION(replace)) {
       return StringReplaceRegExpWithFunction(subject, search, replace);
     } else {
       return StringReplaceRegExp(subject, search, replace);
     }
   }
@@ skipping 217 matching lines @@
   for (var j = 0; j < m; j++) {
     parameters[j] = CaptureString(subject, captures, j);
   }
   parameters[j] = index;
   parameters[j + 1] = subject;
   return ToString(replace.apply(null, parameters));
 }
 
 
 // ECMA-262 section 15.5.4.7
-%AddProperty($String.prototype, "indexOf", function(searchString /* position */) {  // length == 1
+%AddProperty($String.prototype, "indexOf", function indexOf(searchString /* position */) {  // length == 1
   var subject_str = ToString(this);
   var pattern_str = ToString(searchString);
   var subject_str_len = subject_str.length;
   var pattern_str_len = pattern_str.length;
   var index = 0;
   if (%_ArgumentsLength() > 1) {
     var arg1 = %_Arguments(1);  // position
     index = TO_INTEGER(arg1);
   }
   if (index < 0) index = 0;
   if (index > subject_str_len) index = subject_str_len;
   if (pattern_str_len + index > subject_str_len) return -1;
   return %StringIndexOf(subject_str, pattern_str, index);
 }, DONT_ENUM);
 
 
 // ECMA-262 section 15.5.4.8
-%AddProperty($String.prototype, "lastIndexOf", function(searchString /* position */) {  // length == 1
+%AddProperty($String.prototype, "lastIndexOf", function lastIndexOf(searchString /* position */) {  // length == 1
   var sub = ToString(this);
   var pat = ToString(searchString);
   var index = (%_ArgumentsLength() > 1)
       ? ToNumber(%_Arguments(1) /* position */)
       : $NaN;
   var firstIndex;
   if ($isNaN(index)) {
     firstIndex = sub.length - pat.length;
   } else {
     firstIndex = TO_INTEGER(index);
     if (firstIndex + pat.length > sub.length) {
       firstIndex = sub.length - pat.length;
     }
   }
   return %StringLastIndexOf(sub, pat, firstIndex);
 }, DONT_ENUM);
 
 
 // ECMA-262 section 15.5.4.9
 //
 // This function is implementation specific.  For now, we do not
 // do anything locale specific.
-%AddProperty($String.prototype, "localeCompare", function(other) {
+%AddProperty($String.prototype, "localeCompare", function localeCompare(other) {
   if (%_ArgumentsLength() === 0) return 0;
 
   var this_str = ToString(this);
   var other_str = ToString(other);
   return %StringLocaleCompare(this_str, other_str);
 }, DONT_ENUM);
 
 
 // ECMA-262 section 15.5.4.10
-%AddProperty($String.prototype, "match", function(regexp) {
+%AddProperty($String.prototype, "match", function match(regexp) {
   if (!IS_REGEXP(regexp)) regexp = new ORIGINAL_REGEXP(regexp);
   var subject = ToString(this);
 
   if (!regexp.global) return regexp.exec(subject);
   var matches = DoRegExpExecGlobal(regexp, subject);
 
   // If the regexp did not match, return null.
   if (matches.length == 0) return null;
 
   // Build the result array.
   var result = new $Array(match_string);
   for (var i = 0; i < matches.length; ++i) {
     var match = matches[i];
     var match_string = subject.slice(match[0], match[1]);
     result[i] = match_string;
   }
 
   return result;
 }, DONT_ENUM);
 
 
 // ECMA-262 section 15.5.4.12
-%AddProperty($String.prototype, "search", function(re) {
+%AddProperty($String.prototype, "search", function search(re) {
   var regexp = new ORIGINAL_REGEXP(re);
   var s = ToString(this);
   var last_idx = regexp.lastIndex; // keep old lastIndex
   regexp.lastIndex = 0;            // ignore re.global property
   var result = regexp.exec(s);
   regexp.lastIndex = last_idx;     // restore lastIndex
   if (result == null)
     return -1;
   else
     return result.index;
 }, DONT_ENUM);
 
 
 // ECMA-262 section 15.5.4.13
-%AddProperty($String.prototype, "slice", function(start, end) {
+%AddProperty($String.prototype, "slice", function slice(start, end) {
   var s = ToString(this);
   var s_len = s.length;
   var start_i = TO_INTEGER(start);
   var end_i = s_len;
   if (end !== void 0)
     end_i = TO_INTEGER(end);
 
   if (start_i < 0) {
     start_i += s_len;
     if (start_i < 0)
@@ skipping 14 matching lines @@
 
   var num_c = end_i - start_i;
   if (num_c < 0)
     num_c = 0;
 
   return SubString(s, start_i, start_i + num_c);
 }, DONT_ENUM);
 
 
 // ECMA-262 section 15.5.4.14
-%AddProperty($String.prototype, "split", function(separator, limit) {
+%AddProperty($String.prototype, "split", function split(separator, limit) {
   var subject = ToString(this);
   var result = [];
   var lim = (limit === void 0) ? 0xffffffff : ToUint32(limit);
-  
+
   if (lim === 0) return result;
-  
+
   // ECMA-262 says that if separator is undefined, the result should
   // be an array of size 1 containing the entire string.  SpiderMonkey
   // and KJS have this behaviour only when no separator is given.  If
   // undefined is explicitly given, they convert it to a string and
   // use that.  We do as SpiderMonkey and KJS.
   if (%_ArgumentsLength() === 0) {
     result[result.length] = subject;
     return result;
   }
-  
+
   var length = subject.length;
   var currentIndex = 0;
   var startIndex = 0;
-  
+
   var sep = IS_REGEXP(separator) ? separator : ToString(separator);
-  
+
   if (length === 0) {
     if (splitMatch(sep, subject, 0, 0) != null) return result;
     result[result.length] = subject;
     return result;
   }
-  
+
   while (true) {
 
     if (startIndex === length) {
       result[result.length] = subject.slice(currentIndex, length);
       return result;
     }
-    
+
     var match = splitMatch(sep, subject, currentIndex, startIndex);
-    
+
     if (IS_NULL(match)) {
       result[result.length] = subject.slice(currentIndex, length);
       return result;
     }
-    
+
     var endIndex = match[0];
 
     // We ignore a zero-length match at the currentIndex.
     if (startIndex === endIndex && endIndex === currentIndex) {
       startIndex++;
       continue;
     }
 
     result[result.length] = match[1];
     if (result.length === lim) return result;
-    
+
     for (var i = 2; i < match.length; i++) {
       result[result.length] = match[i];
       if (result.length === lim) return result;
     }
-    
+
     startIndex = currentIndex = endIndex;
   }
 }, DONT_ENUM);
 
 
 // ECMA-262 section 15.5.4.14
 // Helper function used by split.
 function splitMatch(separator, subject, current_index, start_index) {
   if (IS_REGEXP(separator)) {
     var ovector = DoRegExpExec(separator, subject, start_index);
     if (ovector == null) return null;
     var nof_results = ovector.length >> 1;
     var result = new $Array(nof_results + 1);
     result[0] = ovector[1];
     result[1] = subject.slice(current_index, ovector[0]);
     for (var i = 1; i < nof_results; i++) {
       var matching_start = ovector[2*i];
       var matching_end = ovector[2*i + 1];
       if (matching_start != -1 && matching_end != -1) {
         result[i + 1] = subject.slice(matching_start, matching_end);
       }
     }
     return result;
   }
-  
+
   var separatorIndex = subject.indexOf(separator, start_index);
   if (separatorIndex === -1) return null;
-  
+
   return [ separatorIndex + separator.length, subject.slice(current_index, separatorIndex) ];
 };
 
 
 // ECMA-262 section 15.5.4.15
-%AddProperty($String.prototype, "substring", function(start, end) {
+%AddProperty($String.prototype, "substring", function substring(start, end) {
   var s = ToString(this);
   var s_len = s.length;
   var start_i = TO_INTEGER(start);
   var end_i = s_len;
   if (!IS_UNDEFINED(end))
     end_i = TO_INTEGER(end);
 
   if (start_i < 0) start_i = 0;
   if (start_i > s_len) start_i = s_len;
   if (end_i < 0) end_i = 0;
   if (end_i > s_len) end_i = s_len;
 
   if (start_i > end_i) {
     var tmp = end_i;
     end_i = start_i;
     start_i = tmp;
   }
 
   return SubString(s, start_i, end_i);
 }, DONT_ENUM);
 
 
 // This is not a part of ECMA-262.
-%AddProperty($String.prototype, "substr", function(start, n) {
+%AddProperty($String.prototype, "substr", function substr(start, n) {
   var s = ToString(this);
   var len;
 
   // Correct n: If not given, set to string length; if explicitly
   // set to undefined, zero, or negative, returns empty string.
   if (n === void 0) {
     len = s.length;
   } else {
     len = TO_INTEGER(n);
     if (len <= 0) return '';
@@ skipping 17 matching lines @@
   }
 
   var end = start + len;
   if (end > s.length) end = s.length;
 
   return SubString(s, start, end);
 }, DONT_ENUM);
 
 
 // ECMA-262, 15.5.4.16
-%AddProperty($String.prototype, "toLowerCase", function() {
+%AddProperty($String.prototype, "toLowerCase", function toLowerCase() {
   return %StringToLowerCase(ToString(this));
 }, DONT_ENUM);
 
 
 // ECMA-262, 15.5.4.17
-%AddProperty($String.prototype, "toLocaleLowerCase", $String.prototype.toLowerCase, DONT_ENUM);
+%AddProperty($String.prototype, "toLocaleLowerCase", function toLocaleLowerCase() {
+  return %StringToLowerCase(ToString(this));
+}, DONT_ENUM);
 
 
 // ECMA-262, 15.5.4.18
-%AddProperty($String.prototype, "toUpperCase", function() {
+%AddProperty($String.prototype, "toUpperCase", function toUpperCase() {
   return %StringToUpperCase(ToString(this));
 }, DONT_ENUM);
 
 
 // ECMA-262, 15.5.4.19
-%AddProperty($String.prototype, "toLocaleUpperCase", $String.prototype.toUpperCase, DONT_ENUM);
+%AddProperty($String.prototype, "toLocaleUpperCase", function toLocaleUpperCase() {
+  return %StringToUpperCase(ToString(this));
+}, DONT_ENUM);
 
 
 // ECMA-262, section 15.5.3.2
-%AddProperty($String, "fromCharCode", function(code) {
+%AddProperty($String, "fromCharCode", function fromCharCode(code) {
   var n = %_ArgumentsLength();
   if (n == 1) return %CharFromCode(ToNumber(code) & 0xffff)
 
   // NOTE: This is not super-efficient, but it is necessary because we
   // want to avoid converting to numbers from within the virtual
   // machine. Maybe we can find another way of doing this?
   var codes = new $Array(n);
   for (var i = 0; i < n; i++) codes[i] = ToNumber(%_Arguments(i));
   return %StringFromCharCodeArray(codes);
 }, DONT_ENUM);
 
 
 // ECMA-262, section 15.5.4.4
-function CharAt(pos) {
+function charAt(pos) {
   var subject = ToString(this);
   var index = TO_INTEGER(pos);
   if (index >= subject.length || index < 0) return "";
   return %CharFromCode(%StringCharCodeAt(subject, index));
 };
 
-%AddProperty($String.prototype, "charAt", CharAt, DONT_ENUM);
+%AddProperty($String.prototype, "charAt", charAt, DONT_ENUM);
 
 
 // Helper function for very basic XSS protection.
 function HtmlEscape(str) {
   return ToString(str).replace(/</g, "&lt;")
                       .replace(/>/g, "&gt;")
                       .replace(/"/g, "&quot;")
                       .replace(/'/g, "&#039;");
 };
 
 
 // Compatibility support for KJS.
 // Tested by mozilla/js/tests/js1_5/Regress/regress-276103.js.
-%AddProperty($String.prototype, "link", function(link) {
-  return "<a href=\"" + HtmlEscape(link) + "\">" + this + "</a>";
+%AddProperty($String.prototype, "link", function link(s) {
+  return "<a href=\"" + HtmlEscape(s) + "\">" + this + "</a>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "anchor", function(name) {
+%AddProperty($String.prototype, "anchor", function anchor(name) {
   return "<a name=\"" + HtmlEscape(name) + "\">" + this + "</a>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "fontcolor", function(color) {
+%AddProperty($String.prototype, "fontcolor", function fontcolor(color) {
   return "<font color=\"" + HtmlEscape(color) + "\">" + this + "</font>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "fontsize", function(size) {
+%AddProperty($String.prototype, "fontsize", function fontsize(size) {
   return "<font size=\"" + HtmlEscape(size) + "\">" + this + "</font>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "big", function() {
+%AddProperty($String.prototype, "big", function big() {
   return "<big>" + this + "</big>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "blink", function() {
+%AddProperty($String.prototype, "blink", function blink() {
   return "<blink>" + this + "</blink>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "bold", function() {
+%AddProperty($String.prototype, "bold", function bold() {
   return "<b>" + this + "</b>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "fixed", function() {
+%AddProperty($String.prototype, "fixed", function fixed() {
   return "<tt>" + this + "</tt>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "italics", function() {
+%AddProperty($String.prototype, "italics", function italics() {
   return "<i>" + this + "</i>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "small", function() {
+%AddProperty($String.prototype, "small", function small() {
   return "<small>" + this + "</small>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "strike", function() {
+%AddProperty($String.prototype, "strike", function strike() {
   return "<strike>" + this + "</strike>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "sub", function() {
+%AddProperty($String.prototype, "sub", function sub() {
   return "<sub>" + this + "</sub>";
 }, DONT_ENUM);
 
 
-%AddProperty($String.prototype, "sup", function() {
+%AddProperty($String.prototype, "sup", function sup() {
   return "<sup>" + this + "</sup>";
 }, DONT_ENUM);
 
 
 // StringBuilder support.
 
 function StringBuilder() {
   this.elements = new $Array();
 }
 
@@ skipping 27 matching lines @@
 
 
 StringBuilder.prototype.generate = function() {
   return %StringBuilderConcat(this.elements, "");
 }
 
 
 ReplaceResultBuilder.prototype.generate = function() {
   return %StringBuilderConcat(this.elements, this.special_string);
 }