Issue 6222004: Cleanup about:flags for remoting and enable for all platforms.

Issue 6222004: Cleanup about:flags for remoting and enable for all platforms. (Closed)

Created:
9 years, 11 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
Sergey Ulanov, dmac

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Cleanup about:flags for remoting and enable for all platforms. BUG=none TEST=compiled and viewed under linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72027

Patch Set 2 : Fix wording a bit. #

Total comments: 2

Patch Set 3 : fix english #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -16 lines)			Patch
	M	chrome/app/generated_resources.grd	View	1 2	1 chunk	+2 lines, -5 lines	0 comments	Download
	M	chrome/browser/about_flags.cc	View	1	1 chunk	+2 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

awong

Updated the wording slightly. Dave, Sergey, can you give it one sanity check?

9 years, 11 months ago (2011-01-20 20:52:23 UTC) #3

dmac

LGTM with small English cleanups http://codereview.chromium.org/6222004/diff/4001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/6222004/diff/4001/chrome/app/generated_resources.grd#newcode4115 chrome/app/generated_resources.grd:4115: Enable the UI, and ...

9 years, 11 months ago (2011-01-20 22:36:02 UTC) #4

Sergey Ulanov

9 years, 11 months ago (2011-01-20 22:36:43 UTC) #5

LGTM, couple nits

http://codereview.chromium.org/6222004/diff/4001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/6222004/diff/4001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4115: Enable the UI, and backing code for the
Remoting serivce process, and client plugin. Warning: This is for developer
testing only still. Unless you are on the dev team, and whitelisted, nothing in
the enabled UI will work.
s/serivce/service/
The word "still" seems to be out of order, maybe "this is still for developer
testing only."

Expand Messages | Collapse Messages