Print Preview: Store preview data in the print preview controller....

chrome/browser/printing/print_preview_tab_controller.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_preview_tab_controller.h"
 
+#include "base/shared_memory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/common/notification_details.h"
 #include "chrome/common/notification_source.h"
 #include "chrome/common/url_constants.h"
 
 namespace printing {
 
 PrintPreviewTabController::PrintPreviewTabController()
     : waiting_for_new_preview_page_(false) {
 }
 
-PrintPreviewTabController::~PrintPreviewTabController() {}
+PrintPreviewTabController::~PrintPreviewTabController() {
+  for (PrintPreviewDataMap::iterator it = preview_data_map_.begin();
+       it != preview_data_map_.end();
+       ++it) {

[kmadhusu, 2011/01/13 18:03:14]

nit: This can fit in the previous line. 

[Lei Zhang, 2011/01/13 20:59:18]

Done.

+    delete it->second.first;  // Deleting SharedMemory;
+  }
+}
 
 // static
 PrintPreviewTabController* PrintPreviewTabController::GetInstance() {
   if (!g_browser_process)
     return NULL;
   return g_browser_process->print_preview_tab_controller();
 }
 
+// static
+bool PrintPreviewTabController::IsPrintPreviewTab(TabContents* tab) {
+  const GURL& url = tab->GetURL();
+  return (url.SchemeIs(chrome::kChromeUIScheme) &&
+          url.host() == chrome::kChromeUIPrintHost);
+}
+
 TabContents* PrintPreviewTabController::GetOrCreatePreviewTab(
     TabContents* initiator_tab, int browser_window_id ) {
   DCHECK(initiator_tab);
 
   // Get the print preview tab for |initiator_tab|.
   TabContents* preview_tab = GetPrintPreviewForTab(initiator_tab);
   if (preview_tab) {
     // Show current preview tab.
     preview_tab->Activate();
     return preview_tab;
   }
   return CreatePrintPreviewTab(initiator_tab, browser_window_id);
 }
 
+bool PrintPreviewTabController::GetPrintPreviewData(TabContents* preview_tab,
+                                                    PrintPreviewData* data) {
+  PrintPreviewDataMap::iterator it = preview_data_map_.find(preview_tab);
+  if (it == preview_data_map_.end())
+    return false;
+  *data = it->second;
+  return true;
+}
+
+bool PrintPreviewTabController::SetPrintPreviewData(
+    TabContents* preview_tab,
+    const PrintPreviewData& data) {
+  PrintPreviewDataMap::iterator it = preview_data_map_.find(preview_tab);
+  if (it == preview_data_map_.end())
+    return false;
+  delete it->second.first;  // Deleting old SharedMemory.
+  it->second = data;
+  return true;
+}
+
 void PrintPreviewTabController::Observe(NotificationType type,
                                         const NotificationSource& source,
                                         const NotificationDetails& details) {
   TabContents* initiator_tab = NULL;
   TabContents* preview_tab = NULL;
   TabContents* source_tab = NULL;
   NavigationController::LoadCommittedDetails* detail_info = NULL;
 
   switch (type.value) {
     case NotificationType::TAB_CONTENTS_DESTROYED: {
@@ skipping 11 matching lines @@
     default: {
       NOTREACHED();
       return;
     }
   }
 
   DCHECK(source_tab);
   preview_tab = GetPrintPreviewForTab(source_tab);
 
   // |source_tab| is preview tab.
-  if (preview_tab == source_tab)
+  if (source_tab == preview_tab)
     initiator_tab = GetInitiatorTab(source_tab);
   else
     initiator_tab = source_tab;
 
   if (detail_info) {
     PageTransition::Type transition_type =
         detail_info->entry->transition_type();
     NavigationType::Type nav_type = detail_info->type;
 
     // Don't update/erase the map entry if the page has not changed.
@@ skipping 13 matching lines @@
 
     // User navigated to a preview tab using forward/back button.
     if (IsPrintPreviewTab(source_tab) &&
         transition_type == PageTransition::FORWARD_BACK &&
         nav_type == NavigationType::EXISTING_PAGE) {
       return;
     }
   }
 
   // If |source_tab| is |initiator_tab|, update the map entry.
-  if (source_tab == initiator_tab) {
+  if (source_tab == initiator_tab)
     preview_tab_map_[preview_tab] = NULL;
-  }
 
   // If |source_tab| is |preview_tab|, erase the map entry.
   if (source_tab == preview_tab) {
     preview_tab_map_.erase(preview_tab);
+    delete preview_data_map_[preview_tab].first;  // Deleting old SharedMemory.
+    preview_data_map_.erase(preview_tab);
     RemoveObservers(preview_tab);
   }
 
   if (initiator_tab)
     RemoveObservers(initiator_tab);
 }
 
-// static
-bool PrintPreviewTabController::IsPrintPreviewTab(TabContents* tab) {
-  const GURL& url = tab->GetURL();
-  return (url.SchemeIs(chrome::kChromeUIScheme) &&
-          url.host() == chrome::kChromeUIPrintHost);
-}
-
 TabContents* PrintPreviewTabController::GetInitiatorTab(
     TabContents* preview_tab) {
   PrintPreviewTabMap::iterator it = preview_tab_map_.find(preview_tab);
   if (it != preview_tab_map_.end())
     return preview_tab_map_[preview_tab];
   return NULL;
 }
 
 TabContents* PrintPreviewTabController::GetPrintPreviewForTab(
     TabContents* tab) {
@@ skipping 17 matching lines @@
                                  PageTransition::LINK);
   params.disposition = NEW_FOREGROUND_TAB;
   params.tabstrip_index = current_browser->tabstrip_model()->
       GetWrapperIndex(initiator_tab) + 1;
   browser::Navigate(&params);
   TabContentsWrapper* preview_tab = params.target_contents;
   preview_tab->tab_contents()->Activate();
 
   // Add an entry to the map.
   preview_tab_map_[preview_tab->tab_contents()] = initiator_tab;
+  preview_data_map_[preview_tab->tab_contents()] =

[kmadhusu, 2011/01/13 18:03:14]

Rather than making calls to the same function consecutively, it would be nice to
pull out "preview_tab->tab_contents()".

[Lei Zhang, 2011/01/13 20:59:18]

Done.

+      std::make_pair(static_cast<base::SharedMemory*>(NULL), 0U);
   waiting_for_new_preview_page_ = true;
 
   AddObservers(initiator_tab);
   AddObservers(preview_tab->tab_contents());
 
   return preview_tab->tab_contents();
 }
 
 void PrintPreviewTabController::AddObservers(TabContents* tab) {
   registrar_.Add(this, NotificationType::TAB_CONTENTS_DESTROYED,
                  Source<TabContents>(tab));
   registrar_.Add(this, NotificationType::NAV_ENTRY_COMMITTED,
                  Source<NavigationController>(&tab->controller()));
 }
 
 void PrintPreviewTabController::RemoveObservers(TabContents* tab) {
   registrar_.Remove(this, NotificationType::TAB_CONTENTS_DESTROYED,
                     Source<TabContents>(tab));
   registrar_.Remove(this, NotificationType::NAV_ENTRY_COMMITTED,
                     Source<NavigationController>(&tab->controller()));
 }
 
 }  // namespace printing