Resource64->32, NaCl side.

Resource 64 bit -> 32 bit, NaCl side.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=4139

[sehr (please use chromium), 2011-01-12 00:55:10]

One comment (no action required), one nit needing a comment, and a question why
we need some output.  Fix at and LGTM.

http://codereview.chromium.org/6218004/diff/20001/tests/fake_browser_ppapi/fa...
File tests/fake_browser_ppapi/fake_host.h (right):

http://codereview.chromium.org/6218004/diff/20001/tests/fake_browser_ppapi/fa...
tests/fake_browser_ppapi/fake_host.h:51: // to be tracked!
We could do this by using a factory pattern for Instances, also, right?

http://codereview.chromium.org/6218004/diff/20001/tests/fake_browser_ppapi/ma...
File tests/fake_browser_ppapi/main.cc (right):

http://codereview.chromium.org/6218004/diff/20001/tests/fake_browser_ppapi/ma...
tests/fake_browser_ppapi/main.cc:81: static PP_Module id = 100;
I presume this number has some significance?  Please comment on why 100 was
used.

http://codereview.chromium.org/6218004/diff/20001/tests/fake_browser_ppapi/ma...
tests/fake_browser_ppapi/main.cc:167: DebugPrintf("TestInstance(): instance
initialized\n");
Do we need these prints?  I think not.

[nfullagar, 2011-01-12 23:08:39]

should the description be
  Resource64->32
instead of
  Resource32->64 ?

[neb, 2011-01-13 00:00:25]

On 2011/01/12 23:08:39, nfullagar wrote:
> should the description be
>   Resource64->32
> instead of
>   Resource32->64 ?

Done.

[neb, 2011-01-13 00:00:43]

http://codereview.chromium.org/6218004/diff/20001/tests/fake_browser_ppapi/fa...
File tests/fake_browser_ppapi/fake_host.h (right):

http://codereview.chromium.org/6218004/diff/20001/tests/fake_browser_ppapi/fa...
tests/fake_browser_ppapi/fake_host.h:51: // to be tracked!
On 2011/01/12 00:55:10, sehr wrote:
> We could do this by using a factory pattern for Instances, also, right?

Yup, but then Instances and Resources have different interfaces (but same
implementation), and we haven't solved the problem for Resources. I don't know -
your call.

We can't do factory for Resources because there's a bunch of different types of
Resources.

http://codereview.chromium.org/6218004/diff/20001/tests/fake_browser_ppapi/ma...
File tests/fake_browser_ppapi/main.cc (right):

http://codereview.chromium.org/6218004/diff/20001/tests/fake_browser_ppapi/ma...
tests/fake_browser_ppapi/main.cc:81: static PP_Module id = 100;
On 2011/01/12 00:55:10, sehr wrote:
> I presume this number has some significance?  Please comment on why 100 was
> used.

Done.

http://codereview.chromium.org/6218004/diff/20001/tests/fake_browser_ppapi/ma...
tests/fake_browser_ppapi/main.cc:167: DebugPrintf("TestInstance(): instance
initialized\n");
On 2011/01/12 00:55:10, sehr wrote:
> Do we need these prints?  I think not.

They sneaked in. Done.