Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 62178: Flesh out more extensions tab api (added removeTab, updateTab) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extension_process_bindings.js
===================================================================
--- chrome/renderer/resources/extension_process_bindings.js (revision 13446)
+++ chrome/renderer/resources/extension_process_bindings.js (working copy)
@@ -6,8 +6,15 @@
// callback handling
var callbacks = [];
chromium._dispatchCallback = function(callbackId, str) {
- callbacks[callbackId](goog.json.parse(str));
- delete callbacks[callbackId];
+ try {
+ if (str) {
+ callbacks[callbackId](goog.json.parse(str));
+ } else {
+ callbacks[callbackId]();
+ }
+ } finally {
+ delete callbacks[callbackId];
+ }
};
// Send an API request and optionally register a callback.
@@ -29,8 +36,20 @@
native function GetTabsForWindow();
sendRequest(GetTabsForWindow, null, callback);
};
+ chromium.tabs.getTab = function(tabId, callback) {
+ native function GetTab();
+ sendRequest(GetTab, tabId, callback);
+ };
chromium.tabs.createTab = function(tab, callback) {
native function CreateTab();
sendRequest(CreateTab, tab, callback);
};
+ chromium.tabs.updateTab = function(tab) {
+ native function UpdateTab();
+ sendRequest(UpdateTab, tab);
+ };
+ chromium.tabs.removeTab = function(tabId) {
+ native function RemoveTab();
+ sendRequest(RemoveTab, tabId);
+ };
})();
« no previous file with comments | « chrome/browser/extensions/extension_tabs_module.cc ('k') | chrome/test/data/extensions/test/TabsAPI/1/jstemplate_compiled.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698