Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: net/disk_cache/entry_impl.cc

Issue 62176: Disk cache: fix broken UMA reports. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/backend_impl.cc ('k') | net/disk_cache/stats.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/entry_impl.cc
===================================================================
--- net/disk_cache/entry_impl.cc (revision 13405)
+++ net/disk_cache/entry_impl.cc (working copy)
@@ -539,6 +539,9 @@
bool EntryImpl::IsDirty(int32 current_id) {
DCHECK(node_.HasData());
+ // We are checking if the entry is valid or not. If there is a pointer here,
+ // |dirty| has to be the id of the cache that is using the entry (the one
+ // that created the pointer), 0 is not a valid id.
if (node_.Data()->pointer && !node_.Data()->dirty)
return true;
« no previous file with comments | « net/disk_cache/backend_impl.cc ('k') | net/disk_cache/stats.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698