Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: net/disk_cache/backend_impl.cc

Issue 6216004: Feature to disable field trials in old versions of Chromium. Field trials... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_thread.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/backend_impl.cc
===================================================================
--- net/disk_cache/backend_impl.cc (revision 71223)
+++ net/disk_cache/backend_impl.cc (working copy)
@@ -174,13 +174,16 @@
// Field trials involve static objects so we have to do this only once.
first = false;
+ std::string group1 = base::StringPrintf("CacheSizeGroup_%d", size_group);
+ // After June 30, 2011 builds, it will always be in defaut group.
rvargas (doing something else) 2011/01/15 00:16:55 nit: Remove the comment, as it doesn't make any se
rtenneti 2011/01/15 00:29:40 Done.
scoped_refptr<base::FieldTrial> trial1(
- new base::FieldTrial("CacheSize", 10));
- std::string group1 = base::StringPrintf("CacheSizeGroup_%d", size_group);
- trial1->AppendGroup(group1, base::FieldTrial::kAllRemainingProbability);
+ new base::FieldTrial("CacheSize", 10, group1, 2011, 6, 30));
+ trial1->group();
+ // After June 30, 2011 builds, it will always be in defaut group.
scoped_refptr<base::FieldTrial> trial2(
- new base::FieldTrial("CacheThrottle", 100));
+ new base::FieldTrial("CacheThrottle", 100, "CacheThrottle_Default", 2011,
+ 6, 30));
int group2a = trial2->AppendGroup("CacheThrottle_On", 10); // 10 % in.
trial2->AppendGroup("CacheThrottle_Off", 10); // 10 % control.
« no previous file with comments | « chrome/renderer/render_thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698