Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issue 62145: Yet another scrape atttempt (Closed)

Created:
11 years, 8 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
eroman, sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Scrape search definitions from forms that have onsubmit handlers. The scraping is done after submit events are handled by the page DOM so doing this is safe. Adds test infrastructure for determining that scraping occurs on submit: - allow testserver to be configured to serve pages from / on the server - provide a ui test util that navigates and waits for N subsequent redirections/navigations before returning control to the test to handle automated submission Eric, please review the test server changes. Scott, please look over everything else. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13444 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13491

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 5

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -31 lines) Patch
A chrome/browser/search_engines/template_url_scraper_unittest.cc View 1 2 1 chunk +90 lines, -0 lines 0 comments Download
A chrome/test/data/template_url_scraper/submit_handler/index.html View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/test/in_process_browser_test.h View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 1 2 3 4 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/test/ui_test_utils.h View 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/ui_test_utils.cc View 2 3 4 4 chunks +26 lines, -5 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M net/base/ssl_client_socket_unittest.cc View 4 1 chunk +3 lines, -3 lines 0 comments Download
M net/base/ssl_test_util.h View 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M net/base/ssl_test_util.cc View 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M net/tools/testserver/testserver.py View 2 3 4 3 chunks +6 lines, -1 line 0 comments Download
M net/url_request/url_request_unittest.h View 2 3 4 7 chunks +18 lines, -9 lines 0 comments Download
M webkit/glue/searchable_form_data.cc View 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M webkit/glue/unittest_test_server.h View 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
11 years, 8 months ago (2009-04-09 03:24:30 UTC) #1
eroman
LGTM on testserver.py. http://codereview.chromium.org/62145/diff/12/1006 File net/tools/testserver/testserver.py (right): http://codereview.chromium.org/62145/diff/12/1006#newcode568 Line 568: prefix=self.server.file_root_url can you add some ...
11 years, 8 months ago (2009-04-09 04:12:02 UTC) #2
sky
11 years, 8 months ago (2009-04-09 15:25:51 UTC) #3
LGTM with the following nits fixed.

http://codereview.chromium.org/62145/diff/12/1004
File chrome/browser/search_engines/template_url_scraper_unittest.cc (right):

http://codereview.chromium.org/62145/diff/12/1004#newcode77
Line 77: EXPECT_EQ(0, all_urls.size() - prepopulate_urls.size());
nit: use EXPECT_EQ(all_urls.size(), prepopulate_urls.size()). That's slightly
easier to debug if things go wrong.

http://codereview.chromium.org/62145/diff/12/1004#newcode78
Line 78: 
nit: nuke extra line.

http://codereview.chromium.org/62145/diff/12/1003
File chrome/test/in_process_browser_test.cc (right):

http://codereview.chromium.org/62145/diff/12/1003#newcode223
Line 223: // lookup.
could you nuke this todo, I don't think there is anything that needs to be done
here.

http://codereview.chromium.org/62145/diff/12/1002
File chrome/test/in_process_browser_test.h (right):

http://codereview.chromium.org/62145/diff/12/1002#newcode70
Line 70: // Allows subclasses to configure the host mapper.
Could you add that this blocks requests to google.com as by default chrome
startup pings google.com and we don't want that during testing.

Powered by Google App Engine
This is Rietveld 408576698