|
Scrape search definitions from forms that have onsubmit handlers. The scraping is done after submit events are handled by the page DOM so doing this is safe.
Adds test infrastructure for determining that scraping occurs on submit:
- allow testserver to be configured to serve pages from / on the server
- provide a ui test util that navigates and waits for N subsequent redirections/navigations before returning control to the test to handle automated submission
Eric, please review the test server changes.
Scott, please look over everything else.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13444
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13491
Total comments: 5
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+212 lines, -31 lines) |
Patch |
 |
A |
chrome/browser/search_engines/template_url_scraper_unittest.cc
|
View
|
1
2
|
1 chunk |
+90 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/test/data/template_url_scraper/submit_handler/index.html
|
View
|
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/test/in_process_browser_test.h
|
View
|
1
2
3
4
|
2 chunks |
+8 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/test/in_process_browser_test.cc
|
View
|
1
2
3
4
|
2 chunks |
+9 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/test/ui_test_utils.h
|
View
|
2
3
4
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/test/ui_test_utils.cc
|
View
|
2
3
4
|
4 chunks |
+26 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/test/unit/unittests.vcproj
|
View
|
1
2
3
4
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
net/base/ssl_client_socket_unittest.cc
|
View
|
4
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/base/ssl_test_util.h
|
View
|
2
3
4
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/base/ssl_test_util.cc
|
View
|
2
3
4
|
2 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/tools/testserver/testserver.py
|
View
|
2
3
4
|
3 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/url_request/url_request_unittest.h
|
View
|
2
3
4
|
7 chunks |
+18 lines, -9 lines |
0 comments
|
Download
|
 |
M |
webkit/glue/searchable_form_data.cc
|
View
|
2
3
4
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
webkit/glue/unittest_test_server.h
|
View
|
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|