Don't leave focus on the next/prior button on the find bar

Ensure the previous/next button don't get focused when clicked.
We keep the button focusable so they can be tab traversed.

BUG=9772
TEST=See bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13364

[Finnur, 2009-04-08 15:22:36]

http://codereview.chromium.org/62144/diff/1/2
File chrome/browser/views/find_bar_view.cc (right):

http://codereview.chromium.org/62144/diff/1/2#newcode438
Line 438: find_text_->RequestFocus();
Wait... what happens if I press Tab twice (starting at the text field)? Will I
make it to the FindNext button? Won't it go from the text-field to the
FindPrevious button and back to the text-field (in a loop).

[Finnur, 2009-04-08 17:26:31]

After speaking with Jay, we agree that this is an appropriate short term fix
that fixes the regression and gets us back to where we were before. 

We'd like to do this only if the button is pressed with the mouse, but our
button handling code doesn't propagate that information down to the listeners. 

Fixing that involves making lots of little changes to the button handler code
(in every file that has a button handler), so we should file a bug and look at
it later. 

Please file the bug and comment this line saying that we should only be doing
this on mouseclick, not keyboard clicks.

With that, LGTM.

On 2009/04/08 15:22:36, Finnur wrote:
> http://codereview.chromium.org/62144/diff/1/2
> File chrome/browser/views/find_bar_view.cc (right):
> 
> http://codereview.chromium.org/62144/diff/1/2#newcode438
> Line 438: find_text_->RequestFocus();
> Wait... what happens if I press Tab twice (starting at the text field)? Will I
> make it to the FindNext button? Won't it go from the text-field to the
> FindPrevious button and back to the text-field (in a loop).