Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 6214003: Show remoting host status on the advanced options page. (Closed)

Created:
9 years, 11 months ago by Sergey Ulanov
Modified:
9 years, 7 months ago
Reviewers:
dmac, Alpha Left Google
CC:
chromium-reviews, Sergey Ulanov, dmac, arv (Not doing code reviews), awong, garykac
Visibility:
Public.

Description

Show remoting host status on the advanced options page. BUG=67218 TEST=Remoting status is shown on the advanced options page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71410

Patch Set 1 #

Total comments: 2

Patch Set 2 : git try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_handler.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_handler.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
A chrome/browser/remoting/remoting_options_handler.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/remoting/remoting_options_handler.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.html View 1 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.js View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/service/service_ipc_server.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/service/service_ipc_server.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
9 years, 11 months ago (2011-01-10 20:58:42 UTC) #1
Alpha Left Google
It seems to me we are sending messages to request host info every time we ...
9 years, 11 months ago (2011-01-11 23:02:46 UTC) #2
Sergey Ulanov
>It seems to me we are sending messages to request host info every time we ...
9 years, 11 months ago (2011-01-12 21:43:22 UTC) #3
Alpha Left Google
9 years, 11 months ago (2011-01-13 19:33:35 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698