chrome/browser/autofill/form_structure_unittest.cc - Issue 6213002: Propagate correct data to the Toolbar servers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/form_structure_unittest.cc

Issue 6213002: Propagate correct data to the Toolbar servers (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/form_structure.cc ('K') | « chrome/browser/autofill/form_structure.cc ('k') | chrome/browser/autofill/personal_data_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/form_structure_unittest.cc

===================================================================

--- chrome/browser/autofill/form_structure_unittest.cc (revision 71339)

+++ chrome/browser/autofill/form_structure_unittest.cc (working copy)

@@ -1671,7 +1671,7 @@

ASSERT_EQ(form_structure->field_count(), possible_field_types.size());

for (size_t i = 0; i < form_structure->field_count(); ++i)

form_structure->set_possible_types(i, possible_field_types[i]);

- EXPECT_TRUE(form_structure->EncodeUploadRequest(false, &encoded_xml));

+ EXPECT_TRUE(form_structure->EncodeUploadRequest(false, "", &encoded_xml));

EXPECT_EQ(encoded_xml,

"<\?xml version=\"1.0\" encoding=\"UTF-8\"\?><autofillupload "

"clientversion=\"6.1.1715.1442/en (GGLL)\" formsignature=\""

@@ -1682,11 +1682,11 @@

"\"14\"/><field signature=\"2799270304\" autofilltype=\"36\"/><field "

"signature=\"1876771436\" autofilltype=\"24\"/><field signature="

"\"263446779\" autofilltype=\"30\"/></autofillupload>");

- EXPECT_TRUE(form_structure->EncodeUploadRequest(true, &encoded_xml));

+ EXPECT_TRUE(form_structure->EncodeUploadRequest(true, "af11", &encoded_xml));

EXPECT_EQ(encoded_xml,

"<\?xml version=\"1.0\" encoding=\"UTF-8\"\?><autofillupload "

"clientversion=\"6.1.1715.1442/en (GGLL)\" formsignature=\""

- "8269229441054798720\" autofillused=\"true\" datapresent=\"\"><field "

+ "8269229441054798720\" autofillused=\"true\" datapresent=\"af11\"><field "

"signature=\"3763331450\" autofilltype=\"3\"/><field signature=\""

"3494530716\" autofilltype=\"5\"/><field signature=\"1029417091\" "

"autofilltype=\"9\"/><field signature=\"466116101\" autofilltype="

@@ -1711,7 +1711,7 @@

ASSERT_EQ(form_structure->field_count(), possible_field_types.size());

for (size_t i = 0; i < form_structure->field_count(); ++i)

form_structure->set_possible_types(i, possible_field_types[i]);

- EXPECT_TRUE(form_structure->EncodeUploadRequest(false, &encoded_xml));

+ EXPECT_TRUE(form_structure->EncodeUploadRequest(false, "", &encoded_xml));

EXPECT_EQ(encoded_xml,

"<\?xml version=\"1.0\" encoding=\"UTF-8\"\?><autofillupload "

"clientversion=\"6.1.1715.1442/en (GGLL)\" formsignature=\""

@@ -1756,7 +1756,7 @@

ASSERT_EQ(form_structure->field_count(), possible_field_types.size());

for (size_t i = 0; i < form_structure->field_count(); ++i)

form_structure->set_possible_types(i, possible_field_types[i]);

- EXPECT_FALSE(form_structure->EncodeUploadRequest(false, &encoded_xml));

+ EXPECT_FALSE(form_structure->EncodeUploadRequest(false, "", &encoded_xml));

EXPECT_EQ(encoded_xml, "");

}