Propagate correct data to the Toolbar servers

chrome/browser/autofill/autofill_download.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 52 matching lines @@
   // |forms| - array of forms aggregated in this request.
   bool StartQueryRequest(const ScopedVector<FormStructure>& forms,
                          const AutoFillMetrics& metric_logger);
 
   // Start upload request if necessary. The probability of request going
   // over the wire are GetPositiveUploadRate() if it was matched by
   // AutoFill, GetNegativeUploadRate() otherwise. Observer will be called
   // even if there was no actual trip over the wire.
   // |form| - form sent in this request.
   // |form_was_matched| - true if form was matched by the AutoFill.
-  bool StartUploadRequest(const FormStructure& form, bool form_was_matched);
+  // |present_data| - hexadecimal representation of the bitfield of the data
+  // presence in user profile.
+  bool StartUploadRequest(const FormStructure& form, bool form_was_matched,
+                          char const* present_data);

[dhollowa, 2011/01/11 23:29:29]

We should use const std::string& for |present_data|.

[GeorgeY, 2011/01/13 23:22:28]

Does not really matter much: the data passed directly to XML build functions
that require const char* anyway, and changing id to std::string will increase
size of the unit-test file :)

 
   // Cancels pending request.
   // |form_signature| - signature of the form being cancelled. Warning:
   // for query request if more than one form sent in the request, all other
   // forms will be cancelled as well.
   // |request_type| - type of the request.
   bool CancelRequest(const std::string& form_signature,
                      AutoFillRequestType request_type);
 
   // Probability of the form upload. Between 0 (no upload) and 1 (upload all).
@@ skipping 50 matching lines @@
   double positive_upload_rate_;
   double negative_upload_rate_;
 
   // Needed for unit-test.
   int fetcher_id_for_unittest_;
   bool is_testing_;
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_