Propagate correct data to the Toolbar servers

chrome/browser/autofill/form_structure.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/form_structure.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/sha1.h"
 #include "base/string_number_conversions.h"
@@ skipping 90 matching lines @@
     method_ = GET;
   }
 }
 
 FormStructure::~FormStructure() {}
 
 bool FormStructure::EncodeUploadRequest(bool auto_fill_used,
                                         std::string* encoded_xml) const {
   DCHECK(encoded_xml);
   encoded_xml->clear();
   bool auto_fillable = IsAutoFillable(false);

[dhollowa, 2011/01/21 03:18:57]

I am unclear why this test is needed.  If I have a form where all fields are of
type UNKNOWN, but I fill in "George" and "Washington" surely I still want to
crowd-source that.

[Ilya Sherman, 2011/01/21 03:30:22]

Yeah, this should be changed to ShouldBeParsed(true) to match the (recently
revised) expectations in AutoFillManager::OnFormSubmitted().

[GeorgeY, 2011/01/21 03:41:32]

Non autofillable forms are bigger than 50 items or shorter than 3. We do not
crowd source that.

[Ilya Sherman, 2011/01/21 03:45:02]

IsAutoFillable() judges the field count based on heuristics.  ShouldBeParsed()
judges the field count based on, well, the raw field count.  Hence, we should
use ShouldBeParsed() =)

Also, I don't recall seeing any code that filters out forms with > 50 items --
where do we do that?

   DCHECK(auto_fillable);  // Caller should've checked for search pages.
   if (!auto_fillable)
     return false;
 
-  buzz::XmlElement autofil_request_xml(buzz::QName("autofillupload"));
+  buzz::XmlElement autofill_request_xml(buzz::QName("autofillupload"));
 
   // Attributes for the <autofillupload> element.
   //
   // TODO(jhawkins): Work with toolbar devs to make a spec for autofill clients.
   // For now these values are hacked from the toolbar code.
-  autofil_request_xml.SetAttr(buzz::QName(kAttributeClientVersion),
-                              "6.1.1715.1442/en (GGLL)");
+  autofill_request_xml.SetAttr(buzz::QName(kAttributeClientVersion),
+                               "6.1.1715.1442/en (GGLL)");
 
-  autofil_request_xml.SetAttr(buzz::QName(kAttributeFormSignature),
-                              FormSignature());
+  autofill_request_xml.SetAttr(buzz::QName(kAttributeFormSignature),
+                               FormSignature());
 
-  autofil_request_xml.SetAttr(buzz::QName(kAttributeAutoFillUsed),
-                              auto_fill_used ? "true" : "false");
+  autofill_request_xml.SetAttr(buzz::QName(kAttributeAutoFillUsed),
+                               auto_fill_used ? "true" : "false");
 
-  // TODO(jhawkins): Hook this up to the personal data manager.
-  // personaldata_manager_->GetDataPresent();
-  autofil_request_xml.SetAttr(buzz::QName(kAttributeDataPresent), "");
+  autofill_request_xml.SetAttr(buzz::QName(kAttributeDataPresent),
+                               ConvertPresenceBitsToString().c_str());
 
-  if (!EncodeFormRequest(FormStructure::UPLOAD, &autofil_request_xml))
+  if (!EncodeFormRequest(FormStructure::UPLOAD, &autofill_request_xml))
     return false;  // Malformed form, skip it.
 
   // Obtain the XML structure as a string.
   *encoded_xml = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>";
-  *encoded_xml += autofil_request_xml.Str().c_str();
+  *encoded_xml += autofill_request_xml.Str().c_str();
 
   return true;
 }
 
 // static
 bool FormStructure::EncodeQueryRequest(const ScopedVector<FormStructure>& forms,
     std::vector<std::string>* encoded_signatures,
     std::string* encoded_xml) {
   DCHECK(encoded_signatures);
   DCHECK(encoded_xml);
   encoded_xml->clear();
   encoded_signatures->clear();
   encoded_signatures->reserve(forms.size());
-  buzz::XmlElement autofil_request_xml(buzz::QName("autofillquery"));
+  buzz::XmlElement autofill_request_xml(buzz::QName("autofillquery"));
   // Attributes for the <autofillquery> element.
   //
   // TODO(jhawkins): Work with toolbar devs to make a spec for autofill clients.
   // For now these values are hacked from the toolbar code.
-  autofil_request_xml.SetAttr(buzz::QName(kAttributeClientVersion),
-                              "6.1.1715.1442/en (GGLL)");
+  autofill_request_xml.SetAttr(buzz::QName(kAttributeClientVersion),
+                               "6.1.1715.1442/en (GGLL)");
   // Some badly formatted web sites repeat forms - detect that and encode only
   // one form as returned data would be the same for all the repeated forms.
   std::set<std::string> processed_forms;
   for (ScopedVector<FormStructure>::const_iterator it = forms.begin();
        it != forms.end();
        ++it) {
     std::string signature((*it)->FormSignature());
     if (processed_forms.find(signature) != processed_forms.end())
       continue;
     processed_forms.insert(signature);
     scoped_ptr<buzz::XmlElement> encompassing_xml_element(
         new buzz::XmlElement(buzz::QName("form")));
     encompassing_xml_element->SetAttr(buzz::QName(kAttributeSignature),
                                       signature);
 
     if (!(*it)->EncodeFormRequest(FormStructure::QUERY,
                                   encompassing_xml_element.get()))
       continue;  // Malformed form, skip it.
 
-    autofil_request_xml.AddElement(encompassing_xml_element.release());
+    autofill_request_xml.AddElement(encompassing_xml_element.release());
     encoded_signatures->push_back(signature);
   }
 
   if (!encoded_signatures->size())
     return false;
 
   // Obtain the XML structure as a string.
   *encoded_xml = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>";
-  *encoded_xml += autofil_request_xml.Str().c_str();
+  *encoded_xml += autofill_request_xml.Str().c_str();
 
   return true;
 }
 
 // static
 void FormStructure::ParseQueryResponse(const std::string& response_xml,
                                        const std::vector<FormStructure*>& forms,
                                        UploadRequired* upload_required,
                                        const AutoFillMetrics& metric_logger) {
   metric_logger.Log(AutoFillMetrics::QUERY_RESPONSE_RECEIVED);
@@ skipping 227 matching lines @@
     } else {
       buzz::XmlElement *field_element = new buzz::XmlElement(
           buzz::QName(kXMLElementField));
       field_element->SetAttr(buzz::QName(kAttributeSignature),
                              field->FieldSignature());
       encompassing_xml_element->AddElement(field_element);
     }
   }
   return true;
 }
+
+std::string FormStructure::ConvertPresenceBitsToString() const {

[dhollowa, 2011/01/21 04:05:43]

It looks like we're setting a bit for UNKNOWN_TYPE.  We probably shouldn't be.

[GeorgeY, 2011/01/21 17:32:37]

Why not? Isn't it a valid bit? I do not really want to special case it (and
NONE, etc.)

+  std::vector<uint8> presence_bitfield;
+  // Determine all of the field types that were autofilled. Pack bits into
+  // |presence_bitfield|. The necessary size for |presence_bitfield| is
+  // ceil((MAX_VALID_FIELD_TYPE + 7) / 8) bytes (uint8).
+  presence_bitfield.resize((MAX_VALID_FIELD_TYPE + 0x7) >> 3);
+  for (size_t i = 0; i < presence_bitfield.size(); ++i)
+    presence_bitfield[i] = 0;
+
+  for (size_t i = 0; i < field_count(); ++i) {
+    const AutoFillField* field = fields_[i];
+    FieldTypeSet types = field->possible_types();
+    for (FieldTypeSet::const_iterator field_type = types.begin();
+         field_type != types.end(); ++field_type) {
+      DCHECK(presence_bitfield.size() >
+             (static_cast<size_t>(*field_type) >> 3));
+      // Set bit in the bitfield: byte |field_type| / 8, bit in byte
+      // |field_type| % 8 from the left.
+      presence_bitfield[*field_type >> 3] |= (0x80 >> (*field_type & 7));

[Ilya Sherman, 2011/01/21 00:25:58]

nit: Is it actually less efficient to write "/ 8" in place of ">> 3" and "& 7"
in place of "% 8"?  I thought compilers were generally smart enough to make that
optimization on their own.

[GeorgeY, 2011/01/21 00:39:02]

Yes, but AFAIK it is both acceptable :)

[Ilya Sherman, 2011/01/21 00:46:51]

Fair enough -- just a bit weird that the code doesn't obviously match the
comment.

[GeorgeY, 2011/01/21 03:41:32]

Changed.
On 2011/01/21 00:46:51, Ilya Sherman wrote:

+    }
+  }
+
+  std::string data_presence;
+  data_presence.reserve(presence_bitfield.size() * 2 + 1);
+
+  // Skip trailing zeroes. If all mask is 0 - return empty string.
+  size_t data_end = presence_bitfield.size();
+  for (; data_end > 0 && !presence_bitfield[data_end - 1]; --data_end) {
+  }
+
+  // Print all non-zero bytes into the string.

[Ilya Sherman, 2011/01/21 00:25:58]

nit: There might be zero bytes printed as well, as long as they are not leading
ones.

[GeorgeY, 2011/01/21 00:39:02]

Rephrased.

+  for (size_t i = 0; i < data_end; ++i) {
+    base::StringAppendF(&data_presence, "%02x", presence_bitfield[i]);
+  }
+
+  return data_presence;
+}
+